Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds support for IREE external parameters at module export time. #155

Merged
merged 3 commits into from
Nov 4, 2023
Merged

Adds support for IREE external parameters at module export time. #155

merged 3 commits into from
Nov 4, 2023

Conversation

stellaraccident
Copy link
Contributor

  • Adds kwargs to builtins that create parameters and globals:
    • external=True : Emit as an external parameter
    • external_scope : Set an explicit external scope
    • name_mapper : Callback to map logical name on the module to parameter name

Requires an IREE nightly bump.

@stellaraccident
Adds support for IREE external parameters at module export time.
6a9a221 
* Adds kwargs to builtins that create parameters and globals:
  * external=True : Emit as an external parameter
  * external_scope : Set an explicit external scope
  * name_mapper : Callback to map logical name on the module to parameter name
dan-garvey
dan-garvey approved these changes Nov 3, 2023
View reviewed changes
Copy link
Member

@dan-garvey dan-garvey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, do we want to start adding e2e tests for stuff like this that include actually loading the parameters, etc? I suppose I should check the roadmap before I ask that

tests/aot/globals_test.py Show resolved Hide resolved
@stellaraccident
Copy link
Contributor Author

lgtm, do we want to start adding e2e tests for stuff like this that include actually loading the parameters, etc? I suppose I should check the roadmap before I ask that

I would like to, yes. Just getting the base infra in first -- but please do if you feel inspired in the meantime. I'm going to have my hands full for the next day just getting some things straightened outside of that.

@stellaraccident stellaraccident merged commit 90bf857 into main Nov 4, 2023
@stellaraccident stellaraccident deleted the external_params branch November 4, 2023 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dan-garvey dan-garvey dan-garvey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stellaraccident @dan-garvey