Dynamo fx completeness #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stellaraccident
approved these changes
Nov 9, 2023
|
Ok I see, added the canonical notation for marking issues fixed. |
IanNod
pushed a commit
that referenced
this pull request
Nov 9, 2023
This PR takes care of #139. For the weird tensor meta data, we should only throw error if quantized. If we start looking at other things like stride, memory_format, etc. the pytest fails. For the TODO where we wanted to throw a KeyError, we already check if parameter.name in node.kwargs in the if statement above, so we won't run into an invalid key. Other issues that were part of this importer completeness task have been addressed and documented. Fixes #139 Fixes #140 Fixes #141 Fixes #142 Fixes #143 Fixes #144
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR takes care of #139.
For the weird tensor meta data, we should only throw error if quantized. If we start looking at other things like stride, memory_format, etc. the pytest fails.
For the TODO where we wanted to throw a KeyError, we already check if parameter.name in node.kwargs in the if statement above, so we won't run into an invalid key.
Other issues that were part of this importer completeness task have been addressed and documented.
Fixes #139
Fixes #140
Fixes #141
Fixes #142
Fixes #143
Fixes #144