-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update FusePackIntoLoop -> FuseProducerIntoLoop to include linalg.copy op #1050
Conversation
compiler/plugins/target/AMD-AIE/iree-amd-aie/Transforms/AMDAIEFuseProducerIntoLoop.cpp
Outdated
Show resolved
Hide resolved
compiler/plugins/target/AMD-AIE/iree-amd-aie/Transforms/test/fuse_producer_into_loop.mlir
Show resolved
Hide resolved
This looks good to me, but an alternative option would be to factorize this into a new pass |
fa8b87b
to
53c6ec3
Compare
I know this trick would work as we used it as an intermediate step in |
:-0 so if those docs are correct you can have an identity IREE::LinalgExt::PackOp but not an identity Linalg::PackOp... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
In cases that
linalg.copy
ops are used instead oftensor.pack
ops as the producers of the computation op, they should be able to be fused into the loops in the same way. This PR updates the pass to handle such cases.