[node-red-node-ui-vega] Append Data into a Vega Chart #65
+18
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello all, any update on this? Please let me know if you suggest any modifications. |
|
@HiroyasuNishiyama - this looks ok to me - but you guys are the main creators and users of this. OK with you ? |
| @@ -84,7 +94,11 @@ loadScripts(["https://cdn.jsdelivr.net/npm/vega@5.20.2", | |||
| if (!vegaEmbed) { | |||
| return; | |||
| } | |||
| showVega(msg.payload); | |||
| if (msg.payload && msg.payload.$schema) { | |||
There was a problem hiding this comment.
Wouldn't this fix break the compatibility of existing code because $schema property is not mandatory?
May I suggest adding msg.command property for setting data structure for controlling Vega specification?
There was a problem hiding this comment.
I'm very sorry.
I didn't realize that I had failed to send the review results.
There was a problem hiding this comment.
That's a good idea. I'll test it out with a msg.command property and update the PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
In node-red charts, when new data is received, it automatically appends that to the chart.
However, in ui_vega, it requires sending a new vega spec (with the updated data) to achieve this.
This introduces a severe lag for a complex spec.
In this PR I added a new function to push just the data into a ui_vega node.
This enables adding new data without triggering a full redraw.
How I've done it (at this point) is by sending messages into the node in two forms: templates and data.
Initially, I wanted to differentiate between them using
msg.topic, but for some reason, it showed up as undefined.For now, I've hacked around it by checking if
msg.payload.$schemais present in the payload.Any design revisions would be appreciated!
Checklist
gruntto verify the unit tests pass