Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove errors.ts as an entry point #152

Closed
wants to merge 1 commit into from
Closed

refactor: remove errors.ts as an entry point #152

wants to merge 1 commit into from

Conversation

legendecas
Copy link
Member

dist/error.js is not exposed in package.json#exports so no need to expose it as an entry point.

Reorganize internal structure to group APIs in src/internal.

@marco-ippolito
Copy link
Member

should we really expose those internals?

@legendecas
Copy link
Member Author

No. Reading nodejs/node#56610, I think this is not useful.

@legendecas legendecas closed this Jan 17, 2025
@legendecas legendecas deleted the entries branch January 17, 2025 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@legendecas @marco-ippolito