Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(test): fix 'npm test' under Node.js 22 #29

Closed
wants to merge 1 commit into from

Conversation

ChALkeR
Copy link
Member

@ChALkeR ChALkeR commented Aug 1, 2024

Dir is not accepted anymore, globs patterns are (not not compatible to 20)
Which means full file paths are ok

Not using '**/*' or '*' as it's not parsed by Node.js 20, not using **/* as not all shells expand it, so *

Assuming all tests are on single level

Refs: https://nodejs.org/api/test.html#running-tests-from-the-command-line

@ChALkeR ChALkeR marked this pull request as ready for review August 1, 2024 19:50
@marco-ippolito
Copy link
Member

marco-ippolito commented Aug 1, 2024

it's fine to use node 22 in the CI if we can support multi level, we can even add => node 22 as engine, it really depends if we are going to backport enable strip-types to v20, which I doubt since it will enter maintainance in october

@marco-ippolito
Copy link
Member

superseded by #21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants