Skip to content

Commit

Permalink
ansible: install V8 build deps for Python 3 (#3418)
Browse files Browse the repository at this point in the history
Ensure `httplib2` and `six` modules are installed for Python 3 on
machines with the `build-test-v8` role.

Refs: nodejs/node#48728
Refs: nodejs/node#48710 (comment)
  • Loading branch information
richardlau authored Jul 15, 2023
1 parent 917f85f commit e32c159
Show file tree
Hide file tree
Showing 4 changed files with 17 additions and 6 deletions.
6 changes: 6 additions & 0 deletions ansible/roles/build-test-v8/tasks/partials/centos7.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,3 +8,9 @@
ansible.builtin.yum:
name: ['python2-httplib2', 'python3-httplib2']
state: present

- name: install dependencies for V8 build tools (Python 3)
ansible.builtin.pip:
executable: pip-3
name: ['httplib2', 'six']
state: present
4 changes: 2 additions & 2 deletions ansible/roles/build-test-v8/tasks/partials/rhel7-s390x.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,8 @@
name: httplib2==0.18.0
state: present

- name: install httplib2 for python 3
- name: install dependencies for V8 build tools (Python 3)
ansible.builtin.pip:
executable: pip-3
name: httplib2
name: ['httplib2', 'six']
state: present
2 changes: 1 addition & 1 deletion ansible/roles/build-test-v8/tasks/partials/rhel8-ppc64.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,5 +33,5 @@
- name: install dependencies for V8 build tools (Python 3)
ansible.builtin.pip:
executable: pip-3
name: httplib2
name: ['httplib2','six']
state: present
11 changes: 8 additions & 3 deletions ansible/roles/build-test-v8/tasks/partials/rhel8-s390x.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
# Newer V8 builds require Python 3.8, or later.
- name: install packages required to build V8
ansible.builtin.dnf:
name: ['GConf2-devel', 'python2', 'python2-pip', 'python39', 'python3-httplib2']
name: ['GConf2-devel', 'python2', 'python2-pip', 'python39']
state: present
notify: package updated

Expand All @@ -24,9 +24,14 @@
name: python3
path: /usr/bin/python3.9

# RHEL 8 doesn't have a package for httplib2 for Python 2 so install via pip.
- name: install httplib2
- name: install dependencies for V8 build tools (Python 2)
ansible.builtin.pip:
executable: pip2
name: httplib2
state: present

- name: install dependencies for V8 build tools (Python 3)
ansible.builtin.pip:
executable: pip-3
name: ['httplib2', 'six']
state: present

0 comments on commit e32c159

Please sign in to comment.