Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused openssl headers #1996

Merged
merged 3 commits into from
Nov 15, 2023

Conversation

yehonatanz
Copy link
Contributor

Remove unused OpenSSL headers for architectures other than current one - now for alpine and for node21.
(follow up of #1923 )

Description

See #1923

Motivation and Context

Reducing alpine image sizes by 48MB:
image

Testing Details

Installed bcrypt and hashed a random string.

Types of changes

  • Documentation
  • Version change (Update, remove or add more Node.js versions)
  • Variant change (Update, remove or add more variants, or versions of variants)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Other (none of the above)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING.md document.
  • All new and existing tests passed.

@yehonatanz yehonatanz mentioned this pull request Nov 14, 2023
12 tasks
@PeterDaveHello PeterDaveHello requested a review from a team November 14, 2023 10:55
Copy link

Created PR on the official-images repo (docker-library/official-images#15729). See https://github.com/docker-library/faq#an-images-source-changed-in-git-now-what if you are wondering when it will be available on the Docker Hub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants