Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace undici with native https.request #20

Closed
wants to merge 1 commit into from

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Oct 20, 2024

Refs: #19

Before

Warning is shown about Node.js undici on npm audit

$ npm audit | grep undici
undici  <=5.28.3
CRLF Injection in Nodejs ‘undici’ via host - https://github.com/advisories/GHSA-5r9g-qh6m-jxff
node_modules/undici

After

No warning shown about undici, as the dependency doesn't exist

$ npm audit | grep undici

@trivikr
Copy link
Member Author

trivikr commented Oct 23, 2024

The Node.js native fetch, which is implemented from undici, if available without --experimental-fetch flag since Node.js 18.x

The undici dependency can be replaced with Node.js native fetch instead of https.request after #23 is merged.

@trivikr trivikr closed this Oct 23, 2024
@trivikr trivikr deleted the replace-undici-with-native-http branch October 23, 2024 20:57
@RafaelGSS
Copy link
Member

Considering we are now targeting really old Node.js versions, I believe https should be better as fetch isn't supported on EOL versions.

@trivikr
Copy link
Member Author

trivikr commented Nov 1, 2024

New PR posted at #26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants