feat: allow catching all exceptions #1593
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd like to discuss the naming of the new define We can use |
|
We discuss in the 18 Oct Node-API meeting:
|
NickNaso
reviewed
Oct 21, 2024
| @@ -78,43 +78,61 @@ inline napi_status AttachData(napi_env env, | |||
| // For use in JS to C++ callback wrappers to catch any Napi::Error exceptions | |||
| // and rethrow them as JavaScript exceptions before returning from the callback. | |||
| template <typename Callable> | |||
| inline napi_value WrapCallback(Callable callback) { | |||
| #ifdef NAPI_CPP_EXCEPTIONS | |||
| inline napi_value WrapCallback(napi_env env, Callable callback) { | |||
There was a problem hiding this comment.
Why are adding the env parameter?
There was a problem hiding this comment.
It is needed to construct a new Error object.
NickNaso
reviewed
Oct 21, 2024
KevinEady
force-pushed
the
catch-all-exceptions
branch
from
fc130ef
to
22357ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds new compile-time define (
NAPI_CPP_EXCEPTIONS_ALL) to enable catching all exceptions.Must be under a flag to be semver minor.
TODO:
Fixes: #1555