Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(no-release): add conditional support in #if #52

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

KevinEady
Copy link
Contributor

Uses acorn to create an AST of the condition, then visit the AST to return a result of the conditional: true, false, or undefined (when a result cannot be guaranteed).

Fixes: #51

@KevinEady
Copy link
Contributor Author

I have merged this branch into my local fork, ran the Sync Headers job manually, and got this PR: KevinEady#73 which removes the experimental conditional.

I marked this change as no-release: Once this branch is merged, there will be an update to the headers file via the Sync Headers job. That merge will create a new version of this package. I think that makes sense?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Need Triage
Development

Successfully merging this pull request may close these issues.

Experimental node_api_nogc_env is not stripped
1 participant