-
Notifications
You must be signed in to change notification settings - Fork 120
feat: automatically include cveId trailling #1022
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+105
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1022 +/- ##
=======================================
Coverage 80.58% 80.58%
=======================================
Files 39 39
Lines 4754 4754
=======================================
Hits 3831 3831
Misses 923 923 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
7aaf70c to
46885f4
Compare
marco-ippolito
approved these changes
Jan 2, 2026
46885f4 to
59c0381
Compare
Member
Author
|
I have updated the PR to also handle backport-prs that have the correct PR-URL metadata. |
This was referenced Jan 2, 2026
nodejs-github-bot
pushed a commit
to nodejs/node
that referenced
this pull request
Jan 4, 2026
Security release automation requires that all backport commits include PR-URL metadata in their commit messages. Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com> PR-URL: #61256 Refs: nodejs/node-core-utils#1022 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Aviv Keller <me@aviv.sh>
aduh95
pushed a commit
to nodejs/node
that referenced
this pull request
Jan 9, 2026
Security release automation requires that all backport commits include PR-URL metadata in their commit messages. Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com> PR-URL: #61256 Refs: nodejs/node-core-utils#1022 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Aviv Keller <me@aviv.sh>
aduh95
pushed a commit
to nodejs/node
that referenced
this pull request
Jan 12, 2026
Security release automation requires that all backport commits include PR-URL metadata in their commit messages. Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com> PR-URL: #61256 Refs: nodejs/node-core-utils#1022 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Aviv Keller <me@aviv.sh>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https://github.com/nodejs-private/security-release/issues/47
Having been testing it with upcoming security release and it works well.