Skip to content

Commit

Permalink
build: fix GN build for cares/uv deps
Browse files Browse the repository at this point in the history
PR-URL: #55477
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
  • Loading branch information
zcbenz authored and aduh95 committed Oct 23, 2024
1 parent 66bcf4c commit 194bb0f
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 4 deletions.
8 changes: 4 additions & 4 deletions deps/cares/unofficial.gni
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,10 @@ template("cares_gn_build") {
]
}

include_dirs = [ "src/lib" ]
include_dirs = [
"src/lib",
"src/lib/include",
]
if (is_win) {
include_dirs += [ "config/win32" ]
} else if (is_linux) {
Expand All @@ -55,9 +58,6 @@ template("cares_gn_build") {
}

sources = gypi_values.cares_sources_common
if (is_win) {
sources += gypi_values.cares_sources_win
}
if (is_linux) {
sources += [ "config/linux/ares_config.h" ]
}
Expand Down
1 change: 1 addition & 0 deletions deps/uv/unofficial.gni
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ template("uv_gn_build") {
"-Wno-extra-semi",
"-Wno-implicit-fallthrough",
"-Wno-missing-braces",
"-Wno-sign-compare",
"-Wno-string-conversion",
"-Wno-shadow",
"-Wno-unreachable-code",
Expand Down
1 change: 1 addition & 0 deletions unofficial.gni
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,7 @@ template("node_gn_build") {
"-Wno-extra-semi",
"-Wno-implicit-fallthrough",
"-Wno-macro-redefined",
"-Wno-missing-braces",
"-Wno-return-type",
"-Wno-shadow",
"-Wno-sometimes-uninitialized",
Expand Down

0 comments on commit 194bb0f

Please sign in to comment.