tests moved to new test file

doc/api/cli.md

@@ -1129,11 +1129,9 @@ the [Permission Model][].
 
 Examples can be found in the [File System Permissions][] documentation.
 
-Special shell characters such as `;` must be escaped or quoted:
-
 ```bash
-node --experimental-permission --permission-fs-path-delimiter=\; \
---allow-fs-read=/path/to/index.js index.js
+node --experimental-permission --permission-fs-path-delimiter=";" \
+--allow-fs-read="/path/to/index.js;/path/with,comma" index.js
 ```
 
 ### `--policy-integrity=sri`

src/permission/child_process_permission.cc

@@ -1,6 +1,7 @@
 #include "child_process_permission.h"
 
 #include <string>
+#include <unordered_map>
 #include <vector>
 
 namespace node {

src/permission/child_process_permission.h

@@ -3,6 +3,7 @@
 
 #if defined(NODE_WANT_INTERNALS) && NODE_WANT_INTERNALS
 
+#include <unordered_map>
 #include <vector>
 #include "permission/permission_base.h"
 

src/permission/fs_permission.cc

@@ -11,6 +11,7 @@
 #include <filesystem>
 #include <string>
 #include <string_view>
+#include <unordered_map>
 #include <vector>
 
 namespace {

src/permission/inspector_permission.cc

@@ -1,6 +1,7 @@
 #include "inspector_permission.h"
 
 #include <string>
+#include <unordered_map>
 
 namespace node {
 

src/permission/inspector_permission.h

@@ -4,6 +4,7 @@
 #if defined(NODE_WANT_INTERNALS) && NODE_WANT_INTERNALS
 
 #include <string>
+#include <unordered_map>
 #include "permission/permission_base.h"
 
 namespace node {

src/permission/permission.cc

@@ -10,6 +10,7 @@
 
 #include <memory>
 #include <string>
+#include <unordered_map>
 #include <vector>
 
 namespace node {

src/permission/permission_base.h

@@ -6,6 +6,7 @@
 #include <map>
 #include <string>
 #include <string_view>
+#include <unordered_map>
 #include "v8.h"
 
 namespace node {

src/permission/worker_permission.cc

@@ -1,6 +1,7 @@
 #include "permission/worker_permission.h"
 
 #include <string>
+#include <unordered_map>
 #include <vector>
 
 namespace node {

src/permission/worker_permission.h

@@ -3,6 +3,7 @@
 
 #if defined(NODE_WANT_INTERNALS) && NODE_WANT_INTERNALS
 
+#include <unordered_map>
 #include <vector>
 #include "permission/permission_base.h"
 

test/parallel/test-cli-permission-deny-fs.js

@@ -71,30 +71,6 @@ const path = require('path');
   assert.strictEqual(status, 0);
 }
 
-{
-  const tmpPath = path.resolve('/tmp/');
-  const pathWithComma = path.resolve('/other,path/');
-  const { status, stdout } = spawnSync(
-    process.execPath,
-    [
-      '--experimental-permission',
-      '--allow-fs-write', `${tmpPath};${pathWithComma}`, '--permission-fs-path-delimiter=;', '-e',
-      `console.log(process.permission.has("fs"));
-      console.log(process.permission.has("fs.read"));
-      console.log(process.permission.has("fs.write"));
-      console.log(process.permission.has("fs.write", "/tmp/"));
-      console.log(process.permission.has("fs.write", "/other,path/"));`,
-    ]
-  );
-  const [fs, fsIn, fsOut, fsOutAllowed1, fsOutAllowed2] = stdout.toString().split('\n');
-  assert.strictEqual(fs, 'false');
-  assert.strictEqual(fsIn, 'false');
-  assert.strictEqual(fsOut, 'false');
-  assert.strictEqual(fsOutAllowed1, 'true');
-  assert.strictEqual(fsOutAllowed2, 'true');
-  assert.strictEqual(status, 0);
-}
-
 {
   const { status, stdout } = spawnSync(
     process.execPath,

test/parallel/test-cli-permission-fs-path-delimiter.js

@@ -0,0 +1,55 @@
+'use strict';
+
+const { spawnSync } = require('child_process');
+const assert = require('assert');
+const path = require('path');
+
+{
+  const tmpPath = path.resolve('/tmp/');
+  const pathWithComma = path.resolve('/other,path/');
+  const { status, stdout } = spawnSync(
+    process.execPath,
+    [
+      '--experimental-permission',
+      '--allow-fs-write',
+      `${tmpPath};${pathWithComma}`,
+      '--permission-fs-path-delimiter=;',
+      '-e',
+      `console.log(process.permission.has("fs"));
+      console.log(process.permission.has("fs.read"));
+      console.log(process.permission.has("fs.write"));
+      console.log(process.permission.has("fs.write", "/tmp/"));
+      console.log(process.permission.has("fs.write", "/other,path/"));`,
+    ]
+  );
+  const [fs, fsIn, fsOut, fsOutAllowed1, fsOutAllowed2] = stdout.toString().split('\n');
+  assert.strictEqual(fs, 'false');
+  assert.strictEqual(fsIn, 'false');
+  assert.strictEqual(fsOut, 'false');
+  assert.strictEqual(fsOutAllowed1, 'true');
+  assert.strictEqual(fsOutAllowed2, 'true');
+  assert.strictEqual(status, 0);
+}
+
+{
+  const { status, stdout } = spawnSync(
+    process.execPath,
+    [
+      '--experimental-permission',
+      '--allow-fs-read=*',
+      '--allow-fs-write=/tmp/file,with,comma.txt',
+      '--permission-fs-path-delimiter=;',
+      '-e',
+      `console.log(process.permission.has("fs"));
+      console.log(process.permission.has("fs.read"));
+      console.log(process.permission.has("fs.write"));
+      console.log(process.permission.has("fs.write", "/tmp/file,with,comma.txt"));`,
+    ]
+  );
+  const [fs, fsIn, fsOut, fsOutAllowed] = stdout.toString().split('\n');
+  assert.strictEqual(fs, 'false');
+  assert.strictEqual(fsIn, 'true');
+  assert.strictEqual(fsOut, 'false');
+  assert.strictEqual(fsOutAllowed, 'true');
+  assert.strictEqual(status, 0);
+}