Skip to content

Commit

Permalink
test: update wpt test for webmessaging/broadcastchannel
Browse files Browse the repository at this point in the history
PR-URL: #55205
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
  • Loading branch information
Nahee-Park authored Oct 22, 2024
1 parent e4ca097 commit eb63cd2
Show file tree
Hide file tree
Showing 5 changed files with 14 additions and 3 deletions.
2 changes: 1 addition & 1 deletion test/fixtures/wpt/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ Last update:
- wasm/webapi: https://github.com/web-platform-tests/wpt/tree/fd1b23eeaa/wasm/webapi
- WebCryptoAPI: https://github.com/web-platform-tests/wpt/tree/bef6fa3566/WebCryptoAPI
- webidl/ecmascript-binding/es-exceptions: https://github.com/web-platform-tests/wpt/tree/a370aad338/webidl/ecmascript-binding/es-exceptions
- webmessaging/broadcastchannel: https://github.com/web-platform-tests/wpt/tree/e97fac4791/webmessaging/broadcastchannel
- webmessaging/broadcastchannel: https://github.com/web-platform-tests/wpt/tree/6495c91853/webmessaging/broadcastchannel
- webstorage: https://github.com/web-platform-tests/wpt/tree/9dafa89214/webstorage

[Web Platform Tests]: https://github.com/web-platform-tests/wpt
Expand Down
2 changes: 1 addition & 1 deletion test/fixtures/wpt/versions.json
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@
"path": "webidl/ecmascript-binding/es-exceptions"
},
"webmessaging/broadcastchannel": {
"commit": "e97fac4791931fb7455ba3fad759d362c7108b09",
"commit": "6495c91853a3cf028a401cf4d228fc0b6a5465e4",
"path": "webmessaging/broadcastchannel"
},
"webstorage": {
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
features:
- name: broadcast-channel
files: "**"
8 changes: 8 additions & 0 deletions test/fixtures/wpt/webmessaging/broadcastchannel/basics.any.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,11 @@
test(function() {
assert_throws_js(
TypeError,
() => BroadcastChannel(""),
"Calling BroadcastChannel constructor without 'new' must throw"
);
}, "BroadcastChannel constructor called as normal function");

async_test(t => {
let c1 = new BroadcastChannel('eventType');
let c2 = new BroadcastChannel('eventType');
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -256,7 +256,7 @@
// Since the worker has closed, it's not expected that the
// BroadcastChannel will receive messages (there's a separate test for
// that), so just indicate directly that it's ready to test receiving
// a message from the parent despite the possibility of a race condition.
// a message from the parent dispite the possibility of a race condition.
postMessage('ready');
}
});
Expand Down

0 comments on commit eb63cd2

Please sign in to comment.