Skip to content

Commit

Permalink
fixup! Revert "url: drop ICU requirement for parsing hostnames"
Browse files Browse the repository at this point in the history
  • Loading branch information
aduh95 committed Jul 21, 2023
1 parent 0560f54 commit f3d70d4
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions doc/api/url.md
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ changes:
pr-url: https://github.com/nodejs/node/pull/47339
description: ICU requirement is removed.
- version: REPLACEME
pr-url: https://github.com/nodejs/node/pull/47339
pr-url: https://github.com/nodejs/node/pull/48869
description: ICU requirement is back.
-->

Expand Down Expand Up @@ -1044,7 +1044,7 @@ changes:
pr-url: https://github.com/nodejs/node/pull/47339
description: ICU requirement is removed.
- version: REPLACEME
pr-url: https://github.com/nodejs/node/pull/47339
pr-url: https://github.com/nodejs/node/pull/48869
description: ICU requirement is back.
-->

Check warning on line 1049 in doc/api/url.md

View workflow job for this annotation

GitHub Actions / lint-js-and-md

Items in `changes` list are not in order

Expand Down Expand Up @@ -1092,7 +1092,7 @@ changes:
pr-url: https://github.com/nodejs/node/pull/47339
description: ICU requirement is removed.
- version: REPLACEME
pr-url: https://github.com/nodejs/node/pull/47339
pr-url: https://github.com/nodejs/node/pull/48869
description: ICU requirement is back.
-->

Check warning on line 1097 in doc/api/url.md

View workflow job for this annotation

GitHub Actions / lint-js-and-md

Items in `changes` list are not in order

Expand Down

0 comments on commit f3d70d4

Please sign in to comment.