pass listener

nodejs · Jul 28, 2023 · f977b2e · f977b2e
1 parent 76befb2
commit f977b2e
Showing 1 changed file with 6 additions and 6 deletions.
diff --git a/lib/internal/event_target.js b/lib/internal/event_target.js
@@ -697,23 +697,23 @@ class EventTarget {
   }
 
   // TODO - rename this function
-  removeInternalListener(type, listener) {
-    type = webidl.converters.DOMString(type);
-
+  removeInternalListener(type, listenerWrapper) {
     const root = this[kEvents].get(type);
     if (root === undefined || root.next === undefined)
       return;
 
-    const capture = listener.capture === true;
+    const capture = listenerWrapper.capture === true;
+
+    const listener = listenerWrapper.weak ? listenerWrapper.listener.deref() : listenerWrapper.listener
 
     let handler = root.next;
     while (handler !== undefined) {
-      if (handler === listener) {
+      if (handler === listenerWrapper) {
         handler.remove();
         root.size--;
         if (root.size === 0)
           this[kEvents].delete(type);
-        this[kRemoveListener](root.size, type, listener.listener, capture);
+        this[kRemoveListener](root.size, type, listener, capture);
         break;
       }
       handler = handler.next;