Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v8-updates/test-linux-perf.js is flaky #48861

Open
joyeecheung opened this issue Jul 20, 2023 · 1 comment
Open

v8-updates/test-linux-perf.js is flaky #48861

joyeecheung opened this issue Jul 20, 2023 · 1 comment
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI.

Comments

@joyeecheung
Copy link
Member

joyeecheung commented Jul 20, 2023

Example error: https://ci.nodejs.org/job/node-test-commit-v8-linux/5468/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/console

I wonder if we actually need to check the output of perf script - IIUC we are just checking that linux perf can produce maps for both interpreted and compiled functions. In this case simply checking the perf map should be enough (as long as the mappings are produced, they should appear). Checking the output of perf script may not be robust enough unless we tweak the how the functions are sampled very carefully (but it can still depend a lot on the state of the machine).

@joyeecheung
Copy link
Member Author

Another idea: maybe the lack of interpreted frames was caused by the function being compiled by maglev/sparkplug (--no-opt is only an alias for --no-turbofan), setting it to --max-opt=0 may be more robust

@VoltrexKeyva VoltrexKeyva added the flaky-test Issues and PRs related to the tests with unstable failures on the CI. label Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI.
Projects
None yet
Development

No branches or pull requests

2 participants