You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I wonder if we actually need to check the output of perf script - IIUC we are just checking that linux perf can produce maps for both interpreted and compiled functions. In this case simply checking the perf map should be enough (as long as the mappings are produced, they should appear). Checking the output of perf script may not be robust enough unless we tweak the how the functions are sampled very carefully (but it can still depend a lot on the state of the machine).
The text was updated successfully, but these errors were encountered:
Another idea: maybe the lack of interpreted frames was caused by the function being compiled by maglev/sparkplug (--no-opt is only an alias for --no-turbofan), setting it to --max-opt=0 may be more robust
Example error: https://ci.nodejs.org/job/node-test-commit-v8-linux/5468/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/console
I wonder if we actually need to check the output of
perf script
- IIUC we are just checking that linux perf can produce maps for both interpreted and compiled functions. In this case simply checking the perf map should be enough (as long as the mappings are produced, they should appear). Checking the output ofperf script
may not be robust enough unless we tweak the how the functions are sampled very carefully (but it can still depend a lot on the state of the machine).The text was updated successfully, but these errors were encountered: