Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: use --max-opt=0 instead of --no-opt test-linux-perf.js #48862

Closed
wants to merge 1 commit into from

Conversation

joyeecheung
Copy link
Member

--no-opt only disables turbofan but other compilers may still be enabled, in that case we may not be able to find the interpreted frames if the function is compiled soon enough. Instead use --max-opt=0 which turns off all compilers.

Refs: #48861

--no-opt only disables turbofan but other compilers may still
be enabled, in that case we may not be able to find the
interpreted frames if the function is compiled soon enough.
Instead use --max-opt=0 which turns off all compilers.
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Jul 20, 2023
@lpinca lpinca added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jul 23, 2023
@joyeecheung
Copy link
Member Author

hmm, so the test is still failing, I took a look at the logs again and I think --interpreted-frames-native-stack is actually broken - it was a bit confusing because the test concats the outputs together before testing them, so there are still compiled functions that you can see in the second part of the output, but if you check out the first part of the concatenated output, it's actually all "unknown".

@joyeecheung
Copy link
Member Author

Although from local testing, I am able to get the interpreted names alright, so it might have something to do with the benchmark machine setup?

@joyeecheung
Copy link
Member Author

I think this is not the right approach, because even --max-opt=0 doesn't ensure that V8 won't compile of our target functions (with the baseline compiler), it's completely up to V8 whether it wants to interpret or compile a function...though there might be some other tricks to force V8 interpret one (e.g. making it super big?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants