Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v16.17.0 release proposal #44098

Merged
merged 699 commits into from
Aug 16, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
699 commits
Select commit Hold shift + click to select a range
9ea9797
src,doc,test: add --openssl-shared-config option
danbev May 18, 2022
23ec1a8
doc: update link of `ICU data slicer`
F3n67u Jun 20, 2022
224d3f4
crypto: update Wrapping and unwrapping keys webcrypto example
panva Jun 20, 2022
8d2a256
dns: make promise API fully constructed from `lib/internal/dns/promises`
F3n67u Jun 20, 2022
70ab660
doc: fix Visual Studio 2019 download link
F3n67u Jun 21, 2022
7be07c7
doc,test: clarify timingSafeEqual semantics
tniessen Jun 21, 2022
a5df207
test: replace gc(true) with gc({ type: 'minor' })
tniessen Jun 21, 2022
bf5adf3
test: add WPT tests for dom/events
nissy-dev Jun 22, 2022
e4a5bd1
net: fix net.Server keepalive and noDelay
theanarkh Jun 22, 2022
1da1722
doc: update link to MDN page about dynamic imports
jamesscottbrown Jun 22, 2022
7ce80d8
test: allow EOVERFLOW errors in fs position tests
richardlau Jun 22, 2022
444c1a6
doc: add Juan as a security steward
mhdawson Jun 20, 2022
267e493
doc: move MylesBorins to TSC Emeritus
MylesBorins Jun 21, 2022
65c3e90
test: use unique file names in fs trace test
bnoordhuis Jun 22, 2022
f3e9fd7
test: skip test-v8-serialize-leak on IBM i
richardlau Jun 22, 2022
600505e
build: update main branch name in GH workflow
F3n67u Jun 23, 2022
93de96f
test: refactor to top-level await
meekdenzo Jun 23, 2022
588a84e
crypto: handle webcrypto generateKey() usages edge case
panva Jun 25, 2022
f05fd1a
http: add perf_hooks detail for http request and client
theanarkh Jun 25, 2022
265810a
net: prevent /32 ipv4 mask from matching all ips
supriyo-biswas Jun 25, 2022
3ccf5ac
wasi: use WasmMemoryObject handle for perf (#43544)
devsnek Jun 25, 2022
965367f
meta: update AUTHORS
nodejs-github-bot Jun 26, 2022
a3a845b
crypto: don't disable TLS 1.3 without suites
AdamMajer Jun 27, 2022
04f6511
benchmark: forcefully close processes
ShogunPanda Jun 24, 2022
a97d0ba
lib: fix TODO in `freeze_intrinsics`
aduh95 Jun 27, 2022
aab5adb
lib: use null-prototype objects for property descriptors
aduh95 Jun 27, 2022
a5089c9
tools: fix CJS/ESM toggle on small screens
aduh95 Jun 27, 2022
67e91aa
readline: fix to not access a property on an undefined value
cola119 Jun 28, 2022
e8754f3
test: improve code coverage for SourceMap class
italojs Jun 1, 2022
f4c4113
benchmark: fix fork detection
ShogunPanda Jun 28, 2022
ff5310a
net: fix net keepalive and noDelay
theanarkh Jun 29, 2022
e51c0e9
events: improve `EventListener` validation
daeyeon Jun 29, 2022
d615f3b
tools: update lint-md-dependencies
nodejs-github-bot Jun 29, 2022
a649d01
doc: add `backport-open-vN.x` step to backporting guide
LiviaMedeiros Jun 29, 2022
463f9a6
perf_hooks: add initiatorType getter
RafaelGSS Jun 30, 2022
26e4dc8
src: remove a stale comment in `async_hooks`
daeyeon Jun 30, 2022
fcf74c5
fs: refactor realpath with Map and Set
LiviaMedeiros Jun 30, 2022
6353a4d
src,bootstrap: remove NodeMainInstance::registry_
RaisinTen Jun 30, 2022
c1ea44d
doc: fix icu-small example
mhdawson Jun 27, 2022
8cda415
url: update WHATWG URL parser to align with latest spec
F3n67u Jun 30, 2022
78bedcd
doc: include CVSS mention
RafaelGSS Jun 30, 2022
9f75f26
errors: extract type detection & use in `ERR_INVALID_RETURN_VALUE`
JakobJingleheimer Jul 1, 2022
8c75973
test: mark test-worker-http2-stream-terminate flaky on all platforms
F3n67u Jul 1, 2022
31f4528
doc: promote 0x to tier 4
tony-go Jul 1, 2022
8f475e6
doc: remove dtrace from tierlist
tony-go Jul 1, 2022
33a2902
esm: restore `next<HookName>`'s `context` as optional arg
JakobJingleheimer Jul 2, 2022
4d8daae
test: fix Buffer.from(ArrayBufferView) call
LiviaMedeiros Jun 29, 2022
daadd58
build,test: increase stack size limit on Windows
tniessen Jul 2, 2022
d514ee7
doc: remove lttng from tierlist
tony-go Jun 28, 2022
e5a7b0f
doc: remove windows xperf from tierlist
tony-go Jun 28, 2022
70a4033
module: cjs-module-lexer WebAssembly fallback
guybedford Jul 3, 2022
407beb2
doc: add single executable application initiative
mhdawson Jul 3, 2022
3526282
doc: remove systemtap from tierlist
tony-go Jun 28, 2022
ee10320
doc: remove appmetrics from tierlist
tony-go Jun 28, 2022
b62574c
meta: update AUTHORS
nodejs-github-bot Jul 4, 2022
9bc4ad0
test: fix flaky test-perf-hooks-histogram
santigimeno Jul 4, 2022
d39fd4e
tools: update eslint to 8.19.0
nodejs-github-bot Jul 4, 2022
50a1b26
doc: add daeyeon to triagers
daeyeon Jul 4, 2022
341799a
test: add test to ensure repl doesn't support --input-type
cola119 Jun 21, 2022
a8d1670
doc: improve description of --input-type
cola119 Jun 21, 2022
26cd4e2
doc: fix default of duplex.allowHalfOpen
vweevers Jul 5, 2022
a8980b2
doc: add note regarding special case of 0 stat.size
dougwilson Jul 5, 2022
c941798
doc: improve readability of `dns.md`
0xSanyam Jul 6, 2022
cfb236e
doc: add Geoffrey Booth to TSC
Trott Jul 7, 2022
f42d674
doc: remove extra 'in's
cjihrig Jul 7, 2022
ae70ada
doc: update changelog-maker to the new flags
RafaelGSS Jul 5, 2022
8a69cda
tools: refactor `tools/license2rtf` to ESM
F3n67u May 29, 2022
d9664c3
build: clarify missing clang-format tool
tniessen Jul 7, 2022
4a6649c
src,stream: change return type to `Maybe`
daeyeon Jul 7, 2022
61ddd50
test: improve code coverage for performance_entry
cola119 Jul 8, 2022
6b7c619
bootstrap: move global initialization to js
alenakhineika Jul 8, 2022
db53e9b
http2: log debug only when in debug mode
mabaasit Jul 8, 2022
480a754
assert: callTracker throw a specific error message when possible
MoLow Jul 8, 2022
3b10a94
benchmark: fix output regression
mscdex Jun 30, 2022
953e663
esm: treat `307` and `308` as redirects in HTTPS imports
kidonng Jul 9, 2022
025248b
build: enable GitPod prebuilds
Trott Jul 9, 2022
053368c
util: avoid inline access to Symbol.iterator
cola119 Jul 9, 2022
b9649a4
src: delegate NodeArrayBufferAllocator to v8's allocator
nornagon Jul 9, 2022
11df17c
test: use Object for `tests` variable in fs trace test
F3n67u Jul 9, 2022
303bd08
net: add drop event for net server
theanarkh Jul 9, 2022
3e21ae8
src: fix crash on FSReqPromise destructor
santigimeno Jul 9, 2022
fa74d45
util: mark cwd grey while inspecting errors
BridgeAR Jun 25, 2022
fa89a61
util: remove unnecessary template string
BridgeAR Jun 25, 2022
b2d02bc
net: remove redundant connecting assignment
oyyd Jul 9, 2022
3cda968
doc: remove node-report from support tiers
RafaelGSS Jul 8, 2022
cc5f17f
test: add test for profile command of node inspect
cola119 Jul 9, 2022
78bb3ab
meta: update AUTHORS
nodejs-github-bot Jul 10, 2022
4a2422a
tools: update lint-md-dependencies to rollup@2.76.0
nodejs-github-bot Jul 10, 2022
5a74939
http: add diagnostics channel for http client
theanarkh Jul 10, 2022
c8706f3
cluster, net: fix listen pipe with readable and writable in cluster
theanarkh Jul 10, 2022
97f4cc7
cluster: fix fd leak
theanarkh Jul 11, 2022
a1f1ff1
src: merge RunInThisContext() with RunInContext()
daeyeon Jul 11, 2022
42610cc
test: mark test-gc-http-client-timeout as flaky on arm
legendecas Jul 10, 2022
61b5d4a
cluster: fix closing dgram sockets in cluster workers throws errors
oyyd Jul 11, 2022
987efcb
tools: remove rpm build scripts
bnoordhuis Jul 11, 2022
c7c769f
doc: include last security release date
RafaelGSS Jul 10, 2022
a5e1620
test: mark test-net-connect-reset-until-connected flaky on freebsd
F3n67u Jul 12, 2022
e6baa8a
deps: upgrade npm to 8.14.0
npm-cli-bot Jul 19, 2022
1566854
deps: upgrade npm to 8.15.0
npm-cli-bot Jul 21, 2022
8835898
deps: cherry-pick libuv/libuv@abb109f
bnoordhuis Jul 22, 2022
92051cb
deps: cherry-pick libuv/libuv@3a7b955
bnoordhuis Jul 22, 2022
9a53083
test: add initial test module
cjihrig Feb 9, 2022
3d851d6
module,repl: support 'node:'-only core modules
cjihrig Mar 20, 2022
a4b277c
test_runner: support 'only' tests
cjihrig Apr 4, 2022
cd6f24b
test_runner: add initial CLI runner
cjihrig Apr 15, 2022
c291233
test: improve lib/internal/test_runner/test.js coverage
fossamagna Apr 27, 2022
1a42359
test_runner: add Subtest to tap protocol output
MoLow Jun 19, 2022
27841be
test_runner: use `kEmptyObject`
LiviaMedeiros May 21, 2022
61a2ddc
test_runner: expose `describe` and `it`
MoLow Jun 14, 2022
dccbd9e
test_runner: wait for stderr and stdout to complete
MoLow Jul 8, 2022
4d4dcad
test_runner: cancel on termination
MoLow Jul 8, 2022
0bdc141
test_runner: protect internals against prototype tampering
aduh95 Jul 9, 2022
5dca44d
test_runner: catch errors thrown within `describe`
MoLow Jul 12, 2022
65699a2
doc: add code examples to node test runner
manekinekko Jun 9, 2022
e9ca1ef
test_runner: support timeout for tests
MoLow Jul 14, 2022
f8f1d16
test_runner: fix `it` concurrency
MoLow Jul 15, 2022
26d63f0
lib: implement safe alternatives to `Promise` static methods
aduh95 Jul 10, 2022
3244217
doc: improve test runner timeout docs
tniessen Jul 20, 2022
95a823d
test: fix typo in file name
aduh95 Jul 11, 2022
c284eb3
module: ensure 'node:'-only modules can access node_modules
cjihrig Apr 14, 2022
288d9fb
loader: make `require.resolve` throw for unknown builtin modules
zhmushan Jun 17, 2022
e6186af
module: add isBuiltIn method
hemanth Jul 8, 2022
5fd26da
tools: add script for vulnerability checking
facutuesca Jun 9, 2022
58eebaf
http: defer reentrant execution of Parser::Execute
ShogunPanda Jun 10, 2022
a6d4d31
esm: fix erroneous re-initialization of ESMLoader
JakobJingleheimer Jul 17, 2022
a1e122b
util: add parseArgs module
bcoe May 24, 2022
f99b0d0
test: fix typo in test-stream-toArray
tniessen Jan 21, 2022
112bce3
node-api: explicitly set __cdecl for API functions
vmoroz Apr 18, 2022
8bd2f4e
test: use `assert.match()` instead of `assert(regex.test())`
aduh95 Apr 21, 2022
2b498fe
doc: fix typo in util.parseArgs usage example
michaelficarra Jun 6, 2022
b5eb556
test: add test for short-option followed by its value
cola119 Jun 12, 2022
69f9a3a
url,lib: pass urlsearchparams-constructor.any.js
XadillaX Aug 30, 2021
2a5d5e0
lib: modify `DOMException` to pass WPT
XadillaX Jan 14, 2022
c4dc8b6
stream: add more filter tests
benjamingr Feb 11, 2022
20fa30c
doc: add new useful V8 option
JialuZhang-intel Jun 17, 2022
513f524
v8: add v8.startupSnapshot utils
joyeecheung Apr 18, 2022
7cb71c0
test: skip test-net-connect-reset-until-connected on SmartOS
panva Jun 19, 2022
ccac1fc
src: improve and update ByteSource description
tniessen Jun 25, 2022
a3a2a9e
test: mark test-http-server-request-timeouts-mixed flaky on macOS
F3n67u Jun 28, 2022
993bf7b
test: mark flaky tests on smartos
F3n67u Jun 28, 2022
7c4e1ad
module: also enable subpath imports in REPL
rayw000 Jun 30, 2022
c6bdb5c
doc: fix typo in errors.md
Jul 5, 2022
0167988
events: improve `Event` compatibility
daeyeon Jul 8, 2022
5edfccf
util: add `AggregateError.prototype.errors` to inspect output
LiviaMedeiros Jul 9, 2022
abc134c
lib,src: add source map support for global eval
legendecas Jun 13, 2022
63228ef
esm: throw on any non-2xx response
LiviaMedeiros Jul 9, 2022
087fc8d
test: mark test-http-client-response-timeout flaky
tniessen Jul 12, 2022
75e6933
test: fix coverity warning in test
mhdawson Jun 30, 2022
f7b8340
doc: fix typo in ngtcp2 readme
dancastillo Jul 12, 2022
0bd4a04
repl: use `SafePromiseAll` and `SafePromiseRace`
aduh95 Jul 12, 2022
5315d97
build: add GitHub token permissions for workflows
varunsh-coder Jul 12, 2022
364b67c
src: slim down env-inl.h
bnoordhuis Jul 13, 2022
0f9d5ac
util: refactor to use validateObject
cola119 Jul 13, 2022
409158c
test: add `common.mustNotMutateObjectDeep()`
LiviaMedeiros Jul 12, 2022
e271e34
test: use `common.mustNotMutateObjectDeep()` in immutability tests
LiviaMedeiros Jul 12, 2022
becfcb4
meta: move one or more collaborators to emeritus
nodejs-github-bot Jul 13, 2022
97bda1f
doc: clarify release process for new releasers
RafaelGSS Jul 13, 2022
391e162
build: make GitPod less noisy
Trott Jul 14, 2022
162c7cb
meta: enable blank issues
mcollina Jul 11, 2022
71f7b00
domain: fix vm promise tracking while keeping isolation
Qard Jul 14, 2022
44291af
doc: revert anachronistic 'node:' module require()s in API history notes
DeeDeeG Jul 14, 2022
3c1ed86
lib: improved diagnostics_channel subscribe/unsubscribe
Apr 12, 2022
4884f18
doc: deprecate diagnostics_channel object subscribe method
May 31, 2022
67ecd27
src: fix `napi_check_object_type_tag()`
daeyeon Jul 12, 2022
2a41097
doc: add MoLow to triagers
MoLow Jul 14, 2022
3a32f0e
src: fix node watchdog race condition
theanarkh Jul 14, 2022
49cbed6
v8: serialize BigInt64Array and BigUint64Array
bnoordhuis Jul 15, 2022
302a134
doc: deprecate coercion to integer in process.exit
daeyeon Jul 15, 2022
8c4cf71
doc: update links to MDN page about dynamic imports
derhuerst Jul 15, 2022
a0d055e
doc: add link to diagnostic tools
RafaelGSS Jul 15, 2022
d260569
repl: fix overzealous top-level await
tniessen Jul 15, 2022
fcfb2c9
doc: document ES2022's Error "cause" property
ide Jul 16, 2022
1685332
doc: add platform-windows-arm to who to CC
mhdawson Jul 17, 2022
7a44613
doc: add history info for `global.performance`
aduh95 Jul 17, 2022
b57758b
tools: update eslint to 8.20.0
nodejs-github-bot Jul 17, 2022
5164332
tools: update lint-md-dependencies to rollup@2.77.0
nodejs-github-bot Jul 17, 2022
3449472
crypto: remove unneeded guard
Trott Jul 18, 2022
80d562b
meta: use platform dropdown on flaky template
RafaelGSS Jul 18, 2022
eaa611c
src: use named enum instead of typedef
tniessen Jul 18, 2022
f4cd579
test: add check to test-fs-readfile-tostring-fail
richardlau Jul 18, 2022
3139c11
esm: remove superfluous argument
Trott Jul 18, 2022
be3343a
src: use named struct instead of typedef
tniessen Jul 18, 2022
dff6068
meta: update AUTHORS
nodejs-github-bot Jul 18, 2022
432e305
util: add tokens to parseArgs
shadowspawn Jul 18, 2022
62c27d0
deps: update undici to 5.8.0
nodejs-github-bot Jul 18, 2022
a948fb8
build: add .gitattributes for npm and other shims
hrishikesh-kadam Jul 19, 2022
ff20308
tools: update doc to highlight.js@11.6.0
nodejs-github-bot Jul 19, 2022
918448e
test: ensure NODE_EXTRA_CA_CERTS not set before tests
KrayzeeKev Jul 20, 2022
c6e2eae
doc: add security release specifics to releases.md
BethGriggs Jul 14, 2022
da6041c
doc: mention Win 32-bit openssl build issue
RafaelGSS Jul 15, 2022
7145125
tools: support versioned node shared libs on z/OS
alexcfyung Mar 8, 2022
420c9bb
tools: add support for using API key to vuln checking script
facutuesca Jul 20, 2022
1e1634a
child_process: do not need to count length when maxBuffer is Infinity
theanarkh Jul 21, 2022
082a263
http: add drop request event for http server
theanarkh Jul 22, 2022
01a4434
tools: add verbose flag to inactive TSC finder
Trott Jul 22, 2022
37cf3b9
doc: add F3n67u to collaborators
F3n67u Jul 23, 2022
86fb313
doc: fix typo in http.md
airingursb Jul 23, 2022
c7be356
deps: update hast-util-raw
MoLow Jul 23, 2022
19397a0
test: simplify ReplStream.wait()
tniessen Jul 23, 2022
43a3239
dns: fix cares memory leak
theanarkh Jul 24, 2022
fea892a
dns: fix getServers return undefined
jiahao-si Jul 24, 2022
fe57e56
cluster: send connection to other server when worker drop it
theanarkh Jul 24, 2022
99a3b19
stream: fix 0 transform hwm backpressure
ronag Jul 24, 2022
24cabbf
util: remove unicode support todo for perf implications
Anemy Jul 24, 2022
3c85e0c
doc: remind backporter about v8_embedder_string
kvakil Jul 24, 2022
15da462
process: use `defineProperty` instead of assignment
erights Jul 24, 2022
7a97445
meta: update `node-api` in label-pr-config
daeyeon Jul 24, 2022
067d69f
doc: fix typo in `src/crypto/README.md`
Jianru-Lin Jul 24, 2022
ec3c331
test: fix test http upload timeout
theanarkh Jul 24, 2022
06a6bda
deps: update corepack to 0.12.1
nodejs-github-bot Jul 24, 2022
0d93b42
meta: update AUTHORS
nodejs-github-bot Jul 24, 2022
d528c55
doc: clarify subprocess.stdout/in/err property
cola119 Jul 24, 2022
2730a10
test: simplify test-tls-set-secure-context
tniessen Jul 24, 2022
e220417
test: work scheduled in process.nextTick can keep the event loop alive
andreubotella Jul 24, 2022
60d032b
buffer: do not leak memory if buffer is too big
kvakil Jul 24, 2022
a6710f5
trace_events: trace net connect event
theanarkh Jul 24, 2022
ca747cc
test: remove test-whatwg-events-add-event-listener-options-once.js
F3n67u Jul 24, 2022
5879642
inspector: set sampling interval before start
codebytere Jul 25, 2022
f66872e
net: fix socket._getpeername
daeyeon Jul 25, 2022
3022958
doc: recommend git-node-v8
kvakil Jul 25, 2022
e9b647a
tools: add more options to track flaky tests
aduh95 Jul 25, 2022
bd0e463
doc: improve documentation for safe `Promise` statics alternatives
aduh95 Jul 25, 2022
c37f904
doc: inspector.close undefined in worker threads
kvakil Jul 16, 2022
3a6df62
test: update WPT encoding tests
cola119 Jul 25, 2022
1bd5816
doc: update email and mailmap for BethGriggs
BethGriggs Jul 25, 2022
8adf7d5
lib: add abortSignal.throwIfAborted()
jasnell Nov 24, 2021
f193ac6
test_runner: recieve and pass AbortSignal
MoLow Jul 20, 2022
b1db850
test_runner: do not report an error when tests are passing
aduh95 Jul 21, 2022
a167daa
test_runner: pass signal on timeout
MoLow Jul 24, 2022
e33f6bd
test_runner: validate `timeout` option
aduh95 Jul 24, 2022
6f9c622
test_runner: add support for boolean values for `concurrency` option
98lenvi Jul 24, 2022
90f395d
errors: add support for cause in aborterror
jasnell Nov 28, 2021
2aae868
timers: propagate signal.reason in awaitable timers
jasnell Nov 28, 2021
046deba
stream: use cause options in AbortError constructors
jasnell Nov 28, 2021
fa5ac5a
http2: propagate abortsignal reason in new AbortError constructor
jasnell Nov 28, 2021
e04c8a4
fs: propagate abortsignal reason in new AbortSignal constructors
jasnell Nov 28, 2021
36dd39d
lib: propagate abortsignal reason in new AbortError constructor in blob
jasnell Nov 28, 2021
979c98a
events: propagate abortsignal reason in new AbortError ctor in events
jasnell Nov 28, 2021
0dc96e4
src: pass only Isolate* and env_vars to EnabledDebugList::Parse()
RaisinTen Jul 15, 2022
e3d8893
deps: V8: backport 22698d267667
legendecas Jul 10, 2022
0046b9a
test: add test on worker process.exit in async modules
legendecas Jul 10, 2022
1d09407
tools: add `avoid-prototype-pollution` lint rule
aduh95 Jun 11, 2022
3e33e90
tools: report unsafe string and regex primordials as lint errors
aduh95 Jun 15, 2022
b9ec3b4
tools,doc: add guards against prototype pollution when creating proxies
aduh95 Jun 12, 2022
a8c2418
lib: refactor to avoid unsafe regex primordials
aduh95 Jun 27, 2022
087adbb
events: add `CustomEvent`
daeyeon Jul 17, 2022
7a5de2c
events: expose CustomEvent on global with CLI flag
daeyeon Jul 23, 2022
e6db809
test: refactor ESM tests to improve performance
JakobJingleheimer Jul 29, 2022
ae157d9
esm: fix loader hooks accepting too many arguments
JakobJingleheimer Aug 4, 2022
30187ba
2022-08-16, Version 16.17.0 'Gallium' (LTS)
targos Aug 2, 2022
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
The diff you're trying to view is too large. We only load the first 3000 changed files.
1 change: 1 addition & 0 deletions .eslintignore
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,5 @@ tools/icu
tools/lint-md/lint-md.mjs
benchmark/tmp
doc/**/*.js
!doc/api_assets/*.js
!.eslintrc.js
2 changes: 2 additions & 0 deletions .eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -260,6 +260,7 @@ module.exports = {
'no-useless-concat': 'error',
'no-useless-constructor': 'error',
'no-useless-return': 'error',
'no-var': 'error',
'no-void': 'error',
'no-whitespace-before-property': 'error',
'object-curly-newline': 'error',
Expand Down Expand Up @@ -319,6 +320,7 @@ module.exports = {
'node-core/no-duplicate-requires': 'error',
},
globals: {
CustomEvent: 'readable',
Crypto: 'readable',
CryptoKey: 'readable',
fetch: 'readable',
Expand Down
3 changes: 3 additions & 0 deletions .gitattributes
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
test/fixtures/* -text
vcbuild.bat text eol=crlf
deps/npm/bin/npm text eol=lf
deps/npm/bin/npx text eol=lf
deps/corepack/shims/corepack text eol=lf
tools/msvs/find_python.cmd text eol=crlf
17 changes: 15 additions & 2 deletions .github/ISSUE_TEMPLATE/4-report-a-flaky-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,24 @@ body:
placeholder: e.g. `test-fs-stat-bigint`
validations:
required: true
- type: input
- type: dropdown
attributes:
label: Platform
description: The platform the test is flaky on.
placeholder: e.g. `macos` or `linux`
multiple: true
options:
- AIX
- FreeBSD
- Linux ARM64
- Linux ARMv7
- Linux PPC64LE
- Linux s390x
- Linux x64
- macOS ARM64
- macOS x64
- SmartOS
- Windows
- Other
- type: textarea
attributes:
label: Console output
Expand Down
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE/config.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
blank_issues_enabled: false
blank_issues_enabled: true
contact_links:
- name: ⁉️ Need help with Node.js?
url: https://github.com/nodejs/help
Expand Down
7 changes: 4 additions & 3 deletions .github/label-pr-config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ subSystemLabels:
/^src\/.*win32.*/: c++, windows
/^src\/node_zlib/: c++, zlib
/^src\/tracing/: c++, tracing
/^src\/node_api/: c++, node-api
/^src\/(?:node_api|js_native_api)/: c++, node-api
/^src\/node_http2/: c++, http2
/^src\/node_report/: c++, report
/^src\/node_wasi/: c++, wasi
Expand Down Expand Up @@ -67,7 +67,7 @@ subSystemLabels:
/^tools\/make-v8/: tools, v8 engine, needs-ci
/^tools\/v8_gypfiles/: tools, v8 engine, needs-ci
/^tools\/(code_cache|snapshot)/: needs-ci
/^tools\/build-addons.js/: needs-ci
/^tools\/build-addons.mjs/: needs-ci
# all other tool changes should be marked as such
/^tools\//: tools
/^\.eslint|\.remark|\.editorconfig/: tools
Expand Down Expand Up @@ -117,7 +117,8 @@ exlusiveLabels:
/^test\/inspector\//: test, inspector
/^test\/cctest\/test_inspector/: test, inspector
/^test\/cctest\/test_url/: test, whatwg-url
/^test\/addons-napi\//: test, node-api
/^test\/node-api\//: test, node-api
/^test\/js-native-api\//: test, node-api
/^test\/async-hooks\//: test, async_hooks
/^test\/report\//: test, report
/^test\/fixtures\/es-module/: test, esm
Expand Down
13 changes: 9 additions & 4 deletions .github/workflows/authors.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,25 +6,30 @@ on:

workflow_dispatch:

permissions:
contents: read

jobs:
authors_update:
if: github.repository == 'nodejs/node'
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3
with:
fetch-depth: '0' # This is required to actually get all the authors
persist-credentials: false
- run: tools/update-authors.js # Run the AUTHORS tool
- uses: gr2m/create-or-update-pull-request-action@v1 # Create a PR or update the Action's existing PR
- run: tools/update-authors.mjs # Run the AUTHORS tool
- uses: gr2m/create-or-update-pull-request-action@6720400cad8e74d7adc64640e4e6ea6748b83d8f
# Creates a PR or update the Action's existing PR, or
# no-op if the base branch is already up-to-date.
env:
GITHUB_TOKEN: ${{ secrets.GH_USER_TOKEN }}
with:
author: Node.js GitHub Bot <github-bot@iojs.org>
body: >
Here are some new additions to the AUTHORS file.
This is an automatically generated PR by the
`authors.yml` GitHub Action, which runs `tools/update-authors.js`.
`authors.yml` GitHub Action, which runs `tools/update-authors.mjs`.
branch: actions/authors-update # Custom branch *just* for this Action.
commit-message: 'meta: update AUTHORS'
labels: meta
Expand Down
12 changes: 10 additions & 2 deletions .github/workflows/auto-start-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,13 @@ concurrency: ${{ github.workflow }}
env:
NODE_VERSION: lts/*

permissions:
contents: read

jobs:
get-prs-for-ci:
permissions:
pull-requests: read
if: github.repository == 'nodejs/node'
runs-on: ubuntu-latest
outputs:
Expand All @@ -32,16 +37,19 @@ jobs:
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
start-ci:
permissions:
contents: read
pull-requests: write
needs: get-prs-for-ci
if: needs.get-prs-for-ci.outputs.numbers != ''
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3
with:
persist-credentials: false

- name: Install Node.js
uses: actions/setup-node@v2
uses: actions/setup-node@v3
with:
node-version: ${{ env.NODE_VERSION }}

Expand Down
20 changes: 11 additions & 9 deletions .github/workflows/build-tarball.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ on:
- '!.github/workflows/build-tarball.yml'
push:
branches:
- master
- main
- v[0-9]+.x-staging
- v[0-9]+.x
Expand All @@ -30,18 +29,21 @@ concurrency:

env:
PYTHON_VERSION: '3.10'
FLAKY_TESTS: dontcare
FLAKY_TESTS: keep_retrying

permissions:
contents: read

jobs:
build-tarball:
if: github.event.pull_request.draft == false
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3
with:
persist-credentials: false
- name: Set up Python ${{ env.PYTHON_VERSION }}
uses: actions/setup-python@v2
uses: actions/setup-python@v3
with:
python-version: ${{ env.PYTHON_VERSION }}
- name: Environment Information
Expand All @@ -55,25 +57,25 @@ jobs:
mkdir tarballs
mv *.tar.gz tarballs
- name: Upload tarball artifact
uses: actions/upload-artifact@v2
uses: actions/upload-artifact@v3
with:
name: tarballs
path: tarballs
test-tarball-linux:
needs: build-tarball
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3
with:
persist-credentials: false
- name: Set up Python ${{ env.PYTHON_VERSION }}
uses: actions/setup-python@v2
uses: actions/setup-python@v3
with:
python-version: ${{ env.PYTHON_VERSION }}
- name: Environment Information
run: npx envinfo
- name: Download tarball
uses: actions/download-artifact@v2
uses: actions/download-artifact@v3
with:
name: tarballs
path: tarballs
Expand All @@ -92,4 +94,4 @@ jobs:
- name: Test
run: |
cd $TAR_DIR
make run-ci -j2 V=1 TEST_CI_ARGS="-p dots"
make run-ci -j2 V=1 TEST_CI_ARGS="-p dots --measure-flakiness 9"
10 changes: 6 additions & 4 deletions .github/workflows/build-windows.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ on:
types: [opened, synchronize, reopened, ready_for_review]
push:
branches:
- master
- main
- canary
- v[0-9]+.x-staging
Expand All @@ -25,18 +24,21 @@ concurrency:

env:
PYTHON_VERSION: '3.10'
FLAKY_TESTS: dontcare
FLAKY_TESTS: keep_retrying

permissions:
contents: read

jobs:
build-windows:
if: github.event.pull_request.draft == false
runs-on: windows-2019
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3
with:
persist-credentials: false
- name: Set up Python ${{ env.PYTHON_VERSION }}
uses: actions/setup-python@v2
uses: actions/setup-python@v3
with:
python-version: ${{ env.PYTHON_VERSION }}
- name: Install deps
Expand Down
17 changes: 10 additions & 7 deletions .github/workflows/close-stale-feature-requests.yml
Original file line number Diff line number Diff line change
@@ -1,12 +1,9 @@
name: Close stale feature requests
on:
workflow_dispatch:
inputs:
daysBeforeStale:
description: Idle number of days before marking feature requests stale
required: true
default: 906
type: number
schedule:
# Run every day at 1:00 AM UTC.
- cron: 0 1 * * *

# yamllint disable rule:empty-lines
env:
Expand All @@ -31,15 +28,21 @@ env:
[feature request management document](https://github.com/nodejs/node/blob/HEAD/doc/contributing/feature-request-management.md).
# yamllint enable

permissions:
contents: read

jobs:
stale:
permissions:
issues: write # for actions/stale to close stale issues
pull-requests: write # for actions/stale to close stale PRs
if: github.repository == 'nodejs/node'
runs-on: ubuntu-latest
steps:
- uses: actions/stale@v4
with:
repo-token: ${{ secrets.GITHUB_TOKEN }}
days-before-stale: ${{ github.event.inputs.daysBeforeStale }}
days-before-stale: 180
days-before-close: 30
stale-issue-label: stale
close-issue-message: ${{ env.CLOSE_MESSAGE }}
Expand Down
6 changes: 6 additions & 0 deletions .github/workflows/close-stalled.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,14 @@ env:
is still relevant, or to ping the collaborator who labelled it stalled if
you have any questions.

permissions:
contents: read

jobs:
stale:
permissions:
issues: write # for actions/stale to close stale issues
pull-requests: write # for actions/stale to close stale PRs
if: github.repository == 'nodejs/node'
runs-on: ubuntu-latest
steps:
Expand Down
8 changes: 8 additions & 0 deletions .github/workflows/comment-labeled.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,14 @@ env:
If it should remain open, please leave a comment explaining why it should remain open.
FAST_TRACK_MESSAGE: Fast-track has been requested by @${{ github.actor }}. Please 👍 to approve.

permissions:
contents: read

jobs:
stale-comment:
permissions:
issues: write
pull-requests: write
if: github.repository == 'nodejs/node' && github.event.label.name == 'stalled'
runs-on: ubuntu-latest
steps:
Expand All @@ -23,6 +29,8 @@ jobs:
run: gh issue comment "$NUMBER" --repo ${{ github.repository }} --body "$STALE_MESSAGE"

fast-track:
permissions:
pull-requests: write
if: github.repository == 'nodejs/node' && github.event_name == 'pull_request_target' && github.event.label.name == 'fast-track'
runs-on: ubuntu-latest
steps:
Expand Down
7 changes: 5 additions & 2 deletions .github/workflows/commit-lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@ on: [pull_request]
env:
NODE_VERSION: lts/*

permissions:
contents: read

jobs:
lint-commit-message:
runs-on: ubuntu-latest
Expand All @@ -14,13 +17,13 @@ jobs:
run: |
echo "::set-output name=plusOne::$((${{ github.event.pull_request.commits }} + 1))"
echo "::set-output name=minusOne::$((${{ github.event.pull_request.commits }} - 1))"
- uses: actions/checkout@v2
- uses: actions/checkout@v3
with:
fetch-depth: ${{ steps.nb-of-commits.outputs.plusOne }}
persist-credentials: false
- run: git reset HEAD^2
- name: Install Node.js
uses: actions/setup-node@v2
uses: actions/setup-node@v3
with:
node-version: ${{ env.NODE_VERSION }}
- name: Validate commit message
Expand Down
9 changes: 7 additions & 2 deletions .github/workflows/commit-queue.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,13 @@ concurrency: ${{ github.workflow }}
env:
NODE_VERSION: lts/*

permissions:
contents: read

jobs:
get_mergeable_prs:
permissions:
pull-requests: read
if: github.repository == 'nodejs/node'
runs-on: ubuntu-latest
outputs:
Expand All @@ -42,7 +47,7 @@ jobs:
if: needs.get_mergeable_prs.outputs.numbers != ''
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3
with:
# Needs the whole git history for ncu to work
# See https://github.com/nodejs/node-core-utils/pull/486
Expand All @@ -55,7 +60,7 @@ jobs:

# Install dependencies
- name: Install Node.js
uses: actions/setup-node@v2
uses: actions/setup-node@v3
with:
node-version: ${{ env.NODE_VERSION }}
- name: Install node-core-utils
Expand Down
Loading