Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: yaml lint command in vcbuild script #48422

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

tools: yaml lint command in vcbuild script #48422

wants to merge 6 commits into from

Commits on May 15, 2024

  1. tools: add lint-yaml command to vcbuild script 

    Yaml linting was missing for windows users.
Reversed evaluation order for wsl and GNUMake of lint-yaml and lint-cpp.
Makefile not fully compatible with Windows, so WSL is now preferred.
Added "lint-yaml" command reference into "help" command.
Added "lint-yaml" step to "test" and "lint" commands.
    @lutaok
    lutaok committed May 15, 2024
    Configuration menu
    Copy the full SHA
    873b340 View commit details
    Browse the repository at this point in the history

  2. tool: disable new-lines rule checking

    @lutaok
    lutaok committed May 15, 2024
    Configuration menu
    Copy the full SHA
    6deae69 View commit details
    Browse the repository at this point in the history

  3. eslint: fix lint-js command execution on Windows 

    vcbuild lint-js command would always fail on Windows.
eslint.js would inspect the deleted file and throw Syntax Error.
Since it didn't seem a meaningful file, it got deleted.
    @lutaok
    lutaok committed May 15, 2024
    Configuration menu
    Copy the full SHA
    9d4de0b View commit details
    Browse the repository at this point in the history

  4. fix: revert eslint symlink file deletion 

    This reverts commit 4dbc523d0027b4918fa292438d7d0ce5dc387f93.
    @lutaok
    lutaok committed May 15, 2024
    Configuration menu
    Copy the full SHA
    84fdad7 View commit details
    Browse the repository at this point in the history

  5. chore: set lf eol for yaml files 

    Ref: nodejs#48422
    @lutaok
    lutaok committed May 15, 2024
    Configuration menu
    Copy the full SHA
    afb844f View commit details
    Browse the repository at this point in the history

  6. chore: add yml extension

    @lutaok
    lutaok committed May 15, 2024
    Configuration menu
    Copy the full SHA
    7ec56bb View commit details
    Browse the repository at this point in the history