test_runner: do not spawn run in child processes to prevent infinite loops

[koh110]

Infinite loop occurs when the file in options.files has run.
I send this PR to avoid the risk of occuring infinite loop.

Ref: #48823

[nodejs-github-bot]

Review requested:

• @nodejs/test_runner

[benjamingr]

I don't understand these changes - why would you both run inside the file and run with --test?

[benjamingr]

Thinking about this a bit more I find this behavior pretty confusing to have a specific exception to the options file.

Even if we did this I'd expect the check to be "is this the options file" and not "is it a worker process".

I'll wait for @MoLow or @cjihrig to weigh in but I'm -0.5

[koh110]

If run is included in the file given to files, I think it have risk to fork the process infinitely.
I think that there is a possibility that the user may give it in an unexpected way, such as when specifying it with glob.
So I thought that run called from run should not start.

In order to reduce the number of test files, I wrote the test in the same file as run, I think there is a similar problem when run calls run in anothor file.

[MoLow]

I am also -1 on this change since this situation only happens when you explicitly run() in a directory including this file.
it can easily be worked-around by changing the filename, or by changing the files parameter.
if you don't want either of those, also explicitly checking for process.env.NODE_TEST_CONTEXT in userland will work

[cjihrig]

I would also prefer not to land this. It might be worth a small note in the options.files docs.

[koh110]

How do you think docs should be changed? I'll do it when I have time.

[Mifrill]

Since execFileSync is a synchronous function, it blocks the event loop until the command execution is complete and returns the result as a Buffer or a string, depending on the encoding used, hence to check execution in case of infinite loops, I think should be better to apply await explicitly:

import { promisify } from 'util';
import { execFile } from 'child_process';

const execFilePromise = promisify(execFile);

Suggested change

	execFileSync(
	await execFilePromise(

[cjihrig]

There seems to be agreement that we should not land this. I'm going to close this out, but thanks for the PR.