Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v18.x backport] src: replace idna functions with ada::idna #48873

Closed
wants to merge 3 commits into from
Closed

[v18.x backport] src: replace idna functions with ada::idna #48873

wants to merge 3 commits into from

Commits on Jul 22, 2023

  1. src: replace idna functions with ada::idna 

    Co-authored-by: Daniel Lemire <daniel@lemire.me>
PR-URL: nodejs#47735
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
    @anonrig @lemire
    anonrig and lemire committed Jul 22, 2023
    Configuration menu
    Copy the full SHA
    6c602b3 View commit details
    Browse the repository at this point in the history

  2. test: validate host with commas on url.parse 

    PR-URL: nodejs#48878
Refs: nodejs#48873
Refs: nodejs#48855
Refs: nodejs#48850
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    @anonrig
    anonrig committed Jul 22, 2023
    Configuration menu
    Copy the full SHA
    a0edb33 View commit details
    Browse the repository at this point in the history

  3. lib: remove invalid parameter to toASCII 

    PR-URL: nodejs#48878
Refs: nodejs#48873
Refs: nodejs#48855
Refs: nodejs#48850
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    @anonrig
    anonrig committed Jul 22, 2023
    Configuration menu
    Copy the full SHA
    60f1bb5 View commit details
    Browse the repository at this point in the history