[v18.x backport] url: ensure getter access do not mutate observable symbols #48891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
needs-ci
aduh95
changed the title
|
Benchmark CI: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1354/ Results |
The test's assumptions about RSS are no longer valid, at least with Fedora 38. Closes: nodejs#48490 PR-URL: nodejs#48811 Fixes: nodejs#48490 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
|
Benchmark results are mixed, but I think it makes sense to move forward with this change. |
PR-URL: nodejs#48897 Refs: nodejs#48891 Refs: nodejs#48886 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
aduh95
force-pushed
the
url-observable-symbols-v18.x
branch
from
c73411e
to
eb29d9a
Compare
aduh95
changed the title
anonrig
approved these changes
Jul 26, 2023
anonrig
added
the
author ready
LiviaMedeiros
approved these changes
Jul 27, 2023
| @@ -179,7 +186,7 @@ class URLContext { | |||
| } | |||
|
|
|||
| function isURLSearchParams(self) { | |||
| return self && self[searchParams] && !self[searchParams][searchParams]; | |||
| return self?.[searchParams]; | |||
There was a problem hiding this comment.
Suggested change
| return self?.[searchParams]; | |
| return Boolean(self?.[searchParams]); |
| return this[searchParams]; | ||
|
|
||
| const cachedValue = internalSearchParams.get(this); | ||
| if (cachedValue != null) |
There was a problem hiding this comment.
Suggested change
| if (cachedValue != null) | |
| if (cachedValue !== undefined) |
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Jul 27, 2023
PR-URL: nodejs#48897 Refs: nodejs#48891 Refs: nodejs#48886 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
pluris
pushed a commit
to pluris/node
that referenced
this pull request
Aug 6, 2023
PR-URL: nodejs#48897 Refs: nodejs#48891 Refs: nodejs#48886 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
pluris
pushed a commit
to pluris/node
that referenced
this pull request
Aug 7, 2023
PR-URL: nodejs#48897 Refs: nodejs#48891 Refs: nodejs#48886 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
RafaelGSS
force-pushed
the
v18.x-staging
branch
from
a05f72f
to
e7d2e8e
Compare
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Aug 14, 2023
PR-URL: nodejs#48897 Refs: nodejs#48891 Refs: nodejs#48886 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Aug 14, 2023
PR-URL: nodejs#48897 Refs: nodejs#48891 Refs: nodejs#48886 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
UlisesGascon
pushed a commit
to UlisesGascon/node
that referenced
this pull request
Aug 14, 2023
PR-URL: nodejs#48897 Refs: nodejs#48891 Refs: nodejs#48886 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
|
@aduh95 Is this ready to land on v18.x? |
Yes it is ready. |
ruyadorno
pushed a commit
that referenced
this pull request
Aug 16, 2023
|
Landed in 0beb5ab |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening as draft so we can run benchmarks, if the perf looks OK, I'll open another PR to land the test on
mainfirst.Refs: #48886