-
Notifications
You must be signed in to change notification settings - Fork 29.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v18.x] Backport most ESM and customization hook changes #50669
Commits on Nov 10, 2023
-
esm: move hook execution to separate thread
PR-URL: nodejs#44710 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com> Co-authored-by: Geoffrey Booth <webadmin@geoffreybooth.com> Co-authored-by: Michaël Zasso <targos@protonmail.com>
Configuration menu - View commit details
-
Copy full SHA for 5a0ae4d - Browse repository at this point
Copy the full SHA 5a0ae4dView commit details -
esm: avoid try/catch when validating urls
PR-URL: nodejs#47541 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Configuration menu - View commit details
-
Copy full SHA for 7c878ef - Browse repository at this point
Copy the full SHA 7c878efView commit details -
esm: propagate
process.exit
from the loader thread to the main threadPR-URL: nodejs#47548 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Jacob Smith <jacob@frende.me>
Configuration menu - View commit details
-
Copy full SHA for 4990269 - Browse repository at this point
Copy the full SHA 4990269View commit details -
esm: initialize
import.meta
on evalPR-URL: nodejs#47551 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Jacob Smith <jacob@frende.me>
Configuration menu - View commit details
-
Copy full SHA for 40fa6e4 - Browse repository at this point
Copy the full SHA 40fa6e4View commit details -
esm: remove support for deprecated hooks
Those have been deprecated for a while, it's time. PR-URL: nodejs#47580 Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for d8687c4 - Browse repository at this point
Copy the full SHA d8687c4View commit details -
loader: use default loader as cascaded loader in the in loader worker
Use the default loader as the cascaded loader in the loader worker. Otherwise we spawn loader workers in the loader workers indefinitely. PR-URL: nodejs#47620 Fixes: nodejs#47566 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Configuration menu - View commit details
-
Copy full SHA for ee9cef2 - Browse repository at this point
Copy the full SHA ee9cef2View commit details -
esm: rename
URLCanParse
to be consistentPR-URL: nodejs#47668 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Matthew Aitken <maitken033380023@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for d63f4c4 - Browse repository at this point
Copy the full SHA d63f4c4View commit details -
esm: do not use
'beforeExit'
on the main threadPR-URL: nodejs#47964 Fixes: nodejs#47929 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Configuration menu - View commit details
-
Copy full SHA for a31ca4e - Browse repository at this point
Copy the full SHA a31ca4eView commit details -
esm: handle more error types thrown from the loader thread
PR-URL: nodejs#48247 Refs: nodejs#48240 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Jacob Smith <jacob@frende.me>
Configuration menu - View commit details
-
Copy full SHA for 2bb6dfb - Browse repository at this point
Copy the full SHA 2bb6dfbView commit details -
esm: handle
globalPreload
hook returning a nullish valuePR-URL: nodejs#48249 Fixes: nodejs#48240 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Jacob Smith <jacob@frende.me>
Configuration menu - View commit details
-
Copy full SHA for 09c986e - Browse repository at this point
Copy the full SHA 09c986eView commit details -
esm: remove support for arrays in
import
internal methodThis avoids initializing arrays that we never use, and simplifies the implementation overall. PR-URL: nodejs#48296 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 96edd85 - Browse repository at this point
Copy the full SHA 96edd85View commit details -
typings: fix JSDoc in ESM loader modules
PR-URL: nodejs#48424 Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Configuration menu - View commit details
-
Copy full SHA for a0c10aa - Browse repository at this point
Copy the full SHA a0c10aaView commit details -
module: implement
register
utilityPR-URL: nodejs#46826 Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 1964e25 - Browse repository at this point
Copy the full SHA 1964e25View commit details -
esm: add back
globalPreload
tests and fix failing onesPR-URL: nodejs#48779 Fixes: nodejs#48778 Fixes: nodejs#48516 Refs: nodejs#46402 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Jacob Smith <jacob@frende.me>
Configuration menu - View commit details
-
Copy full SHA for 002a084 - Browse repository at this point
Copy the full SHA 002a084View commit details -
esm: unflag
Module.register
and allow nested loaderimport()
Major functional changes: - Allow `import()` to work within loaders that require other loaders, - Unflag the use of `Module.register`. A new interface `Customizations` has been created in order to unify `ModuleLoader` (previously `DefaultModuleLoader`), `Hooks` and `CustomizedModuleLoader` all of which now implement it: ```ts interface LoadResult { format: ModuleFormat; source: ModuleSource; } interface ResolveResult { format: string; url: URL['href']; } interface Customizations { allowImportMetaResolve: boolean; load(url: string, context: object): Promise<LoadResult> resolve( originalSpecifier: string, parentURL: string, importAssertions: Record<string, string> ): Promise<ResolveResult> resolveSync( originalSpecifier: string, parentURL: string, importAssertions: Record<string, string> ) ResolveResult; register(specifier: string, parentUrl: string): any; forceLoadHooks(): void; importMetaInitialize(meta, context, loader): void; } ``` The `ModuleLoader` class now has `setCustomizations` which takes an object of this shape and delegates its responsibilities to this object if present. Note that two properties `allowImportMetaResolve` and `resolveSync` exist now as a mechanism for `import.meta.resolve` – since `Hooks` does not implement `resolveSync` other loaders cannot use `import.meta.resolve`; `allowImportMetaResolve` is a way of checking for that case instead of invoking `resolveSync` and erroring. Fixes nodejs#48515 Closes nodejs#48439 PR-URL: nodejs#48559 Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Configuration menu - View commit details
-
Copy full SHA for afa2562 - Browse repository at this point
Copy the full SHA afa2562View commit details -
module: ensure successful import returns the same result
PR-URL: nodejs#46662 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Configuration menu - View commit details
-
Copy full SHA for 5de6683 - Browse repository at this point
Copy the full SHA 5de6683View commit details -
test: fix
es-module/test-esm-initialization
PR-URL: nodejs#48880 Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 0a9e81e - Browse repository at this point
Copy the full SHA 0a9e81eView commit details -
fs: make
mkdtemp
accept buffers and URLPR-URL: nodejs#48828 Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 4ffa98f - Browse repository at this point
Copy the full SHA 4ffa98fView commit details -
test: fix some assumptions in tests
Some tests are assuming they will be run from a directory that do not contain any quote or special character in its path. That assumption is not necessary, using `JSON.stringify` or `pathToFileURL` ensures the test can be run whatever the path looks like. PR-URL: nodejs#48958 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Configuration menu - View commit details
-
Copy full SHA for 17ba928 - Browse repository at this point
Copy the full SHA 17ba928View commit details -
test: order
common.mjs
in ASCII orderPR-URL: nodejs#48960 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Configuration menu - View commit details
-
Copy full SHA for 9d44275 - Browse repository at this point
Copy the full SHA 9d44275View commit details -
test: fix snapshot tests when cwd contains spaces or backslashes
Both are valid characters for file names on non-Windows systems. PR-URL: nodejs#48959 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for ce1d396 - Browse repository at this point
Copy the full SHA ce1d396View commit details -
esm: fix typo
parentUrl
->parentURL
PR-URL: nodejs#48999 Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Configuration menu - View commit details
-
Copy full SHA for f5661b0 - Browse repository at this point
Copy the full SHA f5661b0View commit details -
esm: add
initialize
hook, integrate withregister
Follows @giltayar's proposed API: > `register` can pass any data it wants to the loader, which will be passed to the exported `initialize` function of the loader. Additionally, if the user of `register` wants to communicate with the loader, it can just create a `MessageChannel` and pass the port to the loader as data. The `register` API is now: ```ts interface Options { parentUrl?: string; data?: any; transferList?: any[]; } function register(loader: string, parentUrl?: string): any; function register(loader: string, options?: Options): any; ``` This API is backwards compatible with the old one (new arguments are optional and at the end) and allows for passing data into the new `initialize` hook. If this hook returns data it is passed back to `register`: ```ts function initialize(data: any): Promise<any>; ``` **NOTE**: Currently there is no mechanism for a loader to exchange ownership of something back to the caller. Refs: nodejs/loaders#147 PR-URL: nodejs#48842 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Configuration menu - View commit details
-
Copy full SHA for c34870e - Browse repository at this point
Copy the full SHA c34870eView commit details -
test: use
fixtures.fileURL
when appropriatePR-URL: nodejs#48990 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 3d58e49 - Browse repository at this point
Copy the full SHA 3d58e49View commit details -
esm: protect
ERR_UNSUPPORTED_DIR_IMPORT
against prototype pollutionPR-URL: nodejs#49060 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Jacob Smith <jacob@frende.me>
Configuration menu - View commit details
-
Copy full SHA for 61aa405 - Browse repository at this point
Copy the full SHA 61aa405View commit details -
test: reduce flakiness of
test-esm-loader-hooks
PR-URL: nodejs#49105 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 0bfcddc - Browse repository at this point
Copy the full SHA 0bfcddcView commit details -
esm: import.meta.resolve exact module not found errors should return
PR-URL: nodejs#49038 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Jan Krems <jan.krems@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Jacob Smith <jacob@frende.me>
Configuration menu - View commit details
-
Copy full SHA for a256f11 - Browse repository at this point
Copy the full SHA a256f11View commit details -
esm: unflag import.meta.resolve
PR-URL: nodejs#49028 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 73809e2 - Browse repository at this point
Copy the full SHA 73809e2View commit details -
esm: fix
globalPreload
warningPR-URL: nodejs#49069 Fixes: nodejs#49026 Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Jacob Smith <jacob@frende.me>
Configuration menu - View commit details
-
Copy full SHA for 8ec3953 - Browse repository at this point
Copy the full SHA 8ec3953View commit details -
doc: fix name of the flag in
initialize()
docsPR-URL: nodejs#49158 Reviewed-By: Debadree Chatterjee <debadree333@gmail.com> Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Configuration menu - View commit details
-
Copy full SHA for 586bb8f - Browse repository at this point
Copy the full SHA 586bb8fView commit details -
test: refactor
test-esm-loader-hooks
for easier debugging- Always check stderr before stdout as the former would contain error information. - Always match the full stdout to avoid surprises. - Use `deepStrictEqual` when appropriate to get more informative test failures. - Remove leading slashes from relative paths/URLs to not confuse them with absolute paths. - Remove unnecessary `--no-warnings` flag. PR-URL: nodejs#49131 Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Configuration menu - View commit details
-
Copy full SHA for 1c020cc - Browse repository at this point
Copy the full SHA 1c020ccView commit details -
doc: caveat unavailability of
import.meta.resolve
in custom loadersPR-URL: nodejs#49242 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Configuration menu - View commit details
-
Copy full SHA for 222a378 - Browse repository at this point
Copy the full SHA 222a378View commit details -
test: reduce flakiness of
test-esm-loader-hooks
PR-URL: nodejs#49248 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Configuration menu - View commit details
-
Copy full SHA for cf02160 - Browse repository at this point
Copy the full SHA cf02160View commit details -
doc: add signature for
module.register
PR-URL: nodejs#49251 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 0b72534 - Browse repository at this point
Copy the full SHA 0b72534View commit details -
PR-URL: nodejs#49465 Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 3c9111e - Browse repository at this point
Copy the full SHA 3c9111eView commit details
Commits on Nov 11, 2023
-
doc: move and rename loaders section
PR-URL: nodejs#49261 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for f86933b - Browse repository at this point
Copy the full SHA f86933bView commit details -
PR-URL: nodejs#49265 Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for dcf909c - Browse repository at this point
Copy the full SHA dcf909cView commit details -
doc: edit
import.meta.resolve
documentationPR-URL: nodejs#49247 Refs: nodejs#49028 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Guy Bedford <guybedford@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 16580a4 - Browse repository at this point
Copy the full SHA 16580a4View commit details -
PR-URL: nodejs#49040 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for abedad7 - Browse repository at this point
Copy the full SHA abedad7View commit details -
esm: refactor test-esm-named-exports
PR-URL: nodejs#49493 Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for d785f83 - Browse repository at this point
Copy the full SHA d785f83View commit details -
esm: refactor test-esm-loader-resolve-type
PR-URL: nodejs#49493 Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 9a7a8c5 - Browse repository at this point
Copy the full SHA 9a7a8c5View commit details -
esm: remove return value for
Module.register
The current API shape si not great because it's too limited and redundant with the use of `MessagePort`. PR-URL: nodejs#49529 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Jacob Smith <jacob@frende.me>
Configuration menu - View commit details
-
Copy full SHA for fbc7c3e - Browse repository at this point
Copy the full SHA fbc7c3eView commit details -
typings: fix missing property in
ExportedHooks
PR-URL: nodejs#49567 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Configuration menu - View commit details
-
Copy full SHA for 71c4ae3 - Browse repository at this point
Copy the full SHA 71c4ae3View commit details -
test: isolate
globalPreload
testsPR-URL: nodejs#49545 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Jacob Smith <jacob@frende.me>
Configuration menu - View commit details
-
Copy full SHA for a23a4c9 - Browse repository at this point
Copy the full SHA a23a4c9View commit details -
test: increase coverage of
Module.register
andinitialize
hookPR-URL: nodejs#49532 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Configuration menu - View commit details
-
Copy full SHA for 89dce06 - Browse repository at this point
Copy the full SHA 89dce06View commit details -
esm: clarify ERR_REQUIRE_ESM errors
In nodejs#39175, better ESM errors were introduced. This commit tweaks the language in the error slightly to make it clear that there are three different options to resolve the error. Refs: nodejs#39175 PR-URL: nodejs#49521 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Configuration menu - View commit details
-
Copy full SHA for 40ffd28 - Browse repository at this point
Copy the full SHA 40ffd28View commit details -
esm: fix support for
URL
instances inregister
PR-URL: nodejs#49655 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 1a2443a - Browse repository at this point
Copy the full SHA 1a2443aView commit details -
PR-URL: nodejs#49633 Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Guy Bedford <guybedford@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for a29ddb3 - Browse repository at this point
Copy the full SHA a29ddb3View commit details -
esm: fix return type of
import.meta.resolve
PR-URL: nodejs#49698 Fixes: nodejs#49695 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Guy Bedford <guybedford@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 44b345c - Browse repository at this point
Copy the full SHA 44b345cView commit details -
doc: add missing history info for
import.meta.resolve
PR-URL: nodejs#49700 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Jacob Smith <jacob@frende.me>
Configuration menu - View commit details
-
Copy full SHA for aadc39f - Browse repository at this point
Copy the full SHA aadc39fView commit details -
esm: identify parent importing a url with invalid host
PR-URL: nodejs#49736 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Configuration menu - View commit details
-
Copy full SHA for efd4e8c - Browse repository at this point
Copy the full SHA efd4e8cView commit details -
esm: fix cache collision on JSON files using file: URL
PR-URL: nodejs#49887 Fixes: nodejs#49724 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Configuration menu - View commit details
-
Copy full SHA for f85e62f - Browse repository at this point
Copy the full SHA f85e62fView commit details -
lib: merge cjs and esm package json reader caches
PR-URL: nodejs#48477 Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for a600822 - Browse repository at this point
Copy the full SHA a600822View commit details -
esm: require braces for modules code
PR-URL: nodejs#49657 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Jacob Smith <jacob@frende.me>
Configuration menu - View commit details
-
Copy full SHA for c262d3b - Browse repository at this point
Copy the full SHA c262d3bView commit details -
module, esm: jsdoc for modules files
PR-URL: nodejs#49523 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Configuration menu - View commit details
-
Copy full SHA for bd4eda0 - Browse repository at this point
Copy the full SHA bd4eda0View commit details -
module: move helpers out of cjs loader
PR-URL: nodejs#49912 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Configuration menu - View commit details
-
Copy full SHA for 7c5b7f3 - Browse repository at this point
Copy the full SHA 7c5b7f3View commit details -
esm: improve JSDoc annotation of internal functions
Co-authored-by: Geoffrey Booth <webadmin@geoffreybooth.com> PR-URL: nodejs#49959 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Configuration menu - View commit details
-
Copy full SHA for 2f26771 - Browse repository at this point
Copy the full SHA 2f26771View commit details -
esm: --experimental-default-type flag to flip module defaults
PR-URL: nodejs#49869 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for ce76ac2 - Browse repository at this point
Copy the full SHA ce76ac2View commit details -
esm: unflag extensionless javascript and wasm in module scope
PR-URL: nodejs#49974 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Configuration menu - View commit details
-
Copy full SHA for 823adc8 - Browse repository at this point
Copy the full SHA 823adc8View commit details -
util: add
getCwdSafe
internal util fnThis function was first implemented in nodejs#46826, but at some point of the PR implementation this fn was no longer related to the PR. Refs: nodejs#46826 (comment) PR-URL: nodejs#48434 Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 08201aa - Browse repository at this point
Copy the full SHA 08201aaView commit details -
esm: bypass CommonJS loader under --default-type
PR-URL: nodejs#49986 Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 151e812 - Browse repository at this point
Copy the full SHA 151e812View commit details -
tools: update eslint to 8.45.0
PR-URL: nodejs#48793 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 9ed022b - Browse repository at this point
Copy the full SHA 9ed022bView commit details -
tools: update eslint to 8.46.0
PR-URL: nodejs#48966 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Configuration menu - View commit details
-
Copy full SHA for 5c4057a - Browse repository at this point
Copy the full SHA 5c4057aView commit details -
tools: update eslint to 8.47.0
PR-URL: nodejs#49124 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Configuration menu - View commit details
-
Copy full SHA for 9509884 - Browse repository at this point
Copy the full SHA 9509884View commit details -
tools: update eslint to 8.48.0
PR-URL: nodejs#49343 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Configuration menu - View commit details
-
Copy full SHA for 2208832 - Browse repository at this point
Copy the full SHA 2208832View commit details -
tools: update eslint to 8.49.0
PR-URL: nodejs#49586 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Configuration menu - View commit details
-
Copy full SHA for 96dea39 - Browse repository at this point
Copy the full SHA 96dea39View commit details -
tools: update eslint to 8.50.0
PR-URL: nodejs#49989 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Configuration menu - View commit details
-
Copy full SHA for 669e3d7 - Browse repository at this point
Copy the full SHA 669e3d7View commit details -
tools: update eslint to 8.51.0
PR-URL: nodejs#50084 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 83f680f - Browse repository at this point
Copy the full SHA 83f680fView commit details -
esm: use import attributes instead of import assertions
The old import assertions proposal has been renamed to "import attributes" with the follwing major changes: 1. The keyword is now `with` instead of `assert`. 2. Unknown assertions cause an error rather than being ignored, This commit updates the documentation to encourage folks to use the new syntax, and add aliases for module customization hooks. PR-URL: nodejs#50140 Fixes: nodejs#50134 Refs: v8/v8@159c82c Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 5699370 - Browse repository at this point
Copy the full SHA 5699370View commit details -
test: deflake
test-esm-loader-resolve-type
PR-URL: nodejs#50273 Fixes: nodejs#50040 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
Configuration menu - View commit details
-
Copy full SHA for 52901a7 - Browse repository at this point
Copy the full SHA 52901a7View commit details -
test: deflake
test-loaders-workers-spawned
PR-URL: nodejs#50251 Fixes: nodejs#50247 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for bd6512e - Browse repository at this point
Copy the full SHA bd6512eView commit details -
vm: use import attributes instead of import assertions
The old import assertions proposal has been renamed to "import attributes" with the following major changes: 1. The keyword is now `with` instead of `assert`. 2. Unknown assertions cause an error rather than being ignored. This PR updates the documentation to encourage folks to use the new syntax, and add aliases to preserve backward compatibility. PR-URL: nodejs#50141 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Configuration menu - View commit details
-
Copy full SHA for b0829b7 - Browse repository at this point
Copy the full SHA b0829b7View commit details -
test: refactor
test-node-output-errors
The main reason is to not have the test fail if the CWD contains some special URL chars. PR-URL: nodejs#48992 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Configuration menu - View commit details
-
Copy full SHA for 8f9645d - Browse repository at this point
Copy the full SHA 8f9645dView commit details -
test: fix edge snapshot stack traces
PR-URL: nodejs#49659 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Configuration menu - View commit details
-
Copy full SHA for 85b21a8 - Browse repository at this point
Copy the full SHA 85b21a8View commit details -
tools: skip ruff on tools/node_modules
PR-URL: nodejs#49838 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Configuration menu - View commit details
-
Copy full SHA for 3bf8c02 - Browse repository at this point
Copy the full SHA 3bf8c02View commit details