Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v20.17.0 proposal #54447

Merged
merged 176 commits into from
Aug 21, 2024
Merged

v20.17.0 proposal #54447

merged 176 commits into from
Aug 21, 2024

Commits on Aug 8, 2024

  1. module: support require()ing synchronous ESM graphs

    This patch adds `require()` support for synchronous ESM graphs under
    the flag `--experimental-require-module`
    
    This is based on the the following design aspect of ESM:
    
    - The resolution can be synchronous (up to the host)
    - The evaluation of a synchronous graph (without top-level await) is
      also synchronous, and, by the time the module graph is instantiated
      (before evaluation starts), this is is already known.
    
    If `--experimental-require-module` is enabled, and the ECMAScript
    module being loaded by `require()` meets the following requirements:
    
    - Explicitly marked as an ES module with a `"type": "module"` field in
      the closest package.json or a `.mjs` extension.
    - Fully synchronous (contains no top-level `await`).
    
    `require()` will load the requested module as an ES Module, and return
    the module name space object. In this case it is similar to dynamic
    `import()` but is run synchronously and returns the name space object
    directly.
    
    ```mjs
    // point.mjs
    export function distance(a, b) {
      return (b.x - a.x) ** 2 + (b.y - a.y) ** 2;
    }
    class Point {
      constructor(x, y) { this.x = x; this.y = y; }
    }
    export default Point;
    ```
    
    ```cjs
    const required = require('./point.mjs');
    // [Module: null prototype] {
    //   default: [class Point],
    //   distance: [Function: distance]
    // }
    console.log(required);
    
    (async () => {
      const imported = await import('./point.mjs');
      console.log(imported === required);  // true
    })();
    ```
    
    If the module being `require()`'d contains top-level `await`, or the
    module graph it `import`s contains top-level `await`,
    [`ERR_REQUIRE_ASYNC_MODULE`][] will be thrown. In this case, users
    should load the asynchronous module using `import()`.
    
    If `--experimental-print-required-tla` is enabled, instead of throwing
    `ERR_REQUIRE_ASYNC_MODULE` before evaluation, Node.js will evaluate the
    module, try to locate the top-level awaits, and print their location to
    help users fix them.
    
    PR-URL: #51977
    Backport-PR-URL: #53500
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Guy Bedford <guybedford@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
    joyeecheung authored and marco-ippolito committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    cad46af View commit details
    Browse the repository at this point in the history
  2. module: centralize SourceTextModule compilation for builtin loader

    This refactors the code that compiles SourceTextModule for the
    built-in ESM loader to use a common routine so that it's easier
    to customize cache handling for the ESM loader. In addition
    this introduces a common symbol for import.meta and import()
    so that we don't need to create additional closures as handlers,
    since we can get all the information we need from the V8 callback
    already. This should reduce the memory footprint of ESM as well.
    
    PR-URL: #52291
    Backport-PR-URL: #53500
    Refs: #47472
    Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
    Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
    joyeecheung authored and marco-ippolito committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    4dae68c View commit details
    Browse the repository at this point in the history
  3. module: disallow CJS <-> ESM edges in a cycle from require(esm)

    This patch disallows CJS <-> ESM edges when they come from
    require(esm) requested in ESM evalaution.
    
    Drive-by: don't reuse the cache for imported CJS modules to stash
    source code of required ESM because the former is also used for
    cycle detection.
    
    PR-URL: #52264
    Backport-PR-URL: #53500
    Fixes: #52145
    Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
    Reviewed-By: Guy Bedford <guybedford@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    joyeecheung authored and marco-ippolito committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    51b88fa View commit details
    Browse the repository at this point in the history
  4. lib: convert WeakMaps in cjs loader with private symbol properties

    Symbol properties are typically more GC-efficient than using WeakMaps,
    since WeakMap requires ephemeron GC. `module[kModuleExportNames]`
    would be easier to read than `importedCJSCache.get(module).exportNames`
    as well.
    
    PR-URL: #52095
    Backport-PR-URL: #53500
    Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    legendecas authored and marco-ippolito committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    3a2d8bf View commit details
    Browse the repository at this point in the history
  5. module: tidy code and comments

    PR-URL: #52437
    Backport-PR-URL: #53500
    Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
    Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Feng Yu <F3n67u@outlook.com>
    JakobJingleheimer authored and marco-ippolito committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    6c4f477 View commit details
    Browse the repository at this point in the history
  6. module: fix submodules loaded by require() and import()

    Previously there is an edge case where submodules loaded by require()
    may not be loaded by import() again from different intermediate
    edges in the graph. This patch fixes that, added tests, and added
    debug logs.
    
    Drive-by: make loader a private field so it doesn't show up in logs.
    PR-URL: #52487
    Backport-PR-URL: #53500
    Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    joyeecheung authored and marco-ippolito committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    7625dc4 View commit details
    Browse the repository at this point in the history
  7. stream: implement min option for ReadableStreamBYOBReader.read

    PR-URL: #50888
    Backport-PR-URL: #54044
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    MattiasBuelens authored and marco-ippolito committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    4a3ecbf View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2024

  1. stream: update ongoing promise in async iterator return() method

    PR-URL: #52657
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    MattiasBuelens authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    9b82b15 View commit details
    Browse the repository at this point in the history
  2. src: reduce unnecessary serialization of CLI options in C++

    In this patch we split the serialization routine into two different
    routines: `getCLIOptionsValues()` for only serializing the key-value
    pairs and `getCLIOptionsInfo()` for getting additional information such
    as help text etc. The former is used a lot more frequently than the
    latter, which is only used for generating `--help` and building
    `process.allowedNodeEnvironmentFlags`.
    
    `getCLIOptionsValues()` also adds `--no-` entries for boolean options so
    there is no need to special case in the JS land.
    This patch also refactors the option serialization routines to
    use v8::Object constructor that takes key-value pairs in one go
    to avoid calling Map::Set or Object::Set repeatedly which can go
    up to a patched prototype.
    
    PR-URL: #52451
    Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    joyeecheung authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    a6dd864 View commit details
    Browse the repository at this point in the history
  3. bootstrap: print --help message using console.log

    PR-URL: #51463
    Fixes: #51448
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    jcbhmr authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    a52de8c View commit details
    Browse the repository at this point in the history
  4. doc: fix typo

    PR-URL: #53397
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
    Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
    ehsankhfr authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    1cd3c8e View commit details
    Browse the repository at this point in the history
  5. src: remove ArrayBufferAllocator::Reallocate override

    It's being deprecated and removed in V8.
    
    PR-URL: #52910
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    syg authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    62f4f6f View commit details
    Browse the repository at this point in the history
  6. path: add matchesGlob method

    PR-URL: #52881
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    RedYetiDev authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    57b8b8e View commit details
    Browse the repository at this point in the history
  7. crypto: avoid taking ownership of OpenSSL objects

    It is often unnecessary to obtain (shared) ownership of OpenSSL objects
    in this code, and it generally is more costly to do so as opposed to
    just obtaining a pointer to the respective OpenSSL object. Therefore,
    this patch replaces various OpenSSL function calls that take ownership
    with ones that do not.
    
    Refs: #53436
    PR-URL: #53460
    Reviewed-By: Daniel Lemire <daniel@lemire.me>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    tniessen authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    ceb1d5e View commit details
    Browse the repository at this point in the history
  8. esm: move hooks test with others

    Co-authored-by: Gabriel Bota <gabriel.bota@dynatrace.com>
    PR-URL: #53558
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    2 people authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    5d03f6f View commit details
    Browse the repository at this point in the history
  9. doc: note http.closeAllConnections excludes upgraded sockets

    PR-URL: #53560
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Paolo Insogna <paolo@cowtech.it>
    robhogan authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    59c5c5c View commit details
    Browse the repository at this point in the history
  10. meta: prevent constant references to issues in versioning

    PR-URL: #53564
    Reviewed-By: Jithil P Ponnan <jithil@outlook.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
    RedYetiDev authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    bcd08be View commit details
    Browse the repository at this point in the history
  11. doc: clarify that fs.exists() may return false for existing symlink

    Given that this API is problematic in any case, we should be precise
    about its (perhaps surprising) behavior.
    
    PR-URL: #53566
    Reviewed-By: Jithil P Ponnan <jithil@outlook.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
    Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
    tniessen authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    73860ac View commit details
    Browse the repository at this point in the history
  12. doc: document addition testing options

    PR-URL: #53569
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    RedYetiDev authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    f8f247b View commit details
    Browse the repository at this point in the history
  13. doc: clarify usage of coverage reporters

    PR-URL: #53523
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
    eliphazbouye authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    156fc53 View commit details
    Browse the repository at this point in the history
  14. test: refactor, add assertion to http-request-end

    PR-URL: #53411
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    jakecastelli authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    2b70018 View commit details
    Browse the repository at this point in the history
  15. test: fix OpenSSL version checks

    As per the original pull request that introduced the OpenSSL version
    check in `parallel/test-crypto-dh`:
    
    ```
    Error message change is test-only and uses the right error message for
    versions >=3.0.12 in 3.0.x and >= 3.1.4 in 3.1.x series.
    ```
    
    Fix the check so that:
    - The older message is expected for OpenSSL 3.1.0.
    - The newer message is expected for OpenSSL from 3.1.4 (e.g. 3.2.x).
    
    Refs: #50395
    PR-URL: #53503
    Refs: #53382
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    richardlau authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    a075267 View commit details
    Browse the repository at this point in the history
  16. meta: warnings bypass deprecation cycle

    Allow for emitting new warnings without going through a deprecation
    cycle.
    
    Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
    PR-URL: #53513
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    2 people authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    0c91186 View commit details
    Browse the repository at this point in the history
  17. build: add version-specific library path for AIX

    Add the version-specific directory containing the C/C++ runtime
    libraries to `-blibpath` on AIX. This will help link `node` against
    the correct libraries at run-time when compiled with a different
    version of the GNU C/C++ compiler without having to manually set
    a `LIBPATH` environment variable.
    
    PR-URL: #53585
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
    richardlau authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    3d8721f View commit details
    Browse the repository at this point in the history
  18. tools: replace reference to NodeMainInstance with SnapshotBuilder

    Small documentation update from
    `node::NodeMainInstance::GetEmbeddedSnapshotData`
    to `node::SnapshotBuilder::GetEmbeddedSnapshotData`.
    
    PR-URL: #53544
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    codediverdev authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    8404421 View commit details
    Browse the repository at this point in the history
  19. benchmark: add cpSync benchmark

    PR-URL: #53612
    Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
    Reviewed-By: LiviaMedeiros <livia@cirno.name>
    Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    anonrig authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    c7e4c3d View commit details
    Browse the repository at this point in the history
  20. doc, typings: events.once accepts symbol event type

    PR-URL: #53542
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Renegade334 authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    4187b81 View commit details
    Browse the repository at this point in the history
  21. meta: move member from TSC regular to emeriti

    Signed-off-by: Michael Dawson <midawson@redhat.com>
    PR-URL: #53599
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
    mhdawson authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    44d901a View commit details
    Browse the repository at this point in the history
  22. crypto: make deriveBits length parameter optional and nullable

    PR-URL: #53601
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    panva authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    460240c View commit details
    Browse the repository at this point in the history
  23. lib: add toJSON to PerformanceMeasure

    PR-URL: #53603
    Refs: #53570
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    theanarkh authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    1e9ff50 View commit details
    Browse the repository at this point in the history
  24. doc: add esm example for os

    PR-URL: #53604
    Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
    Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    peixotoleonardo authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    16d55f1 View commit details
    Browse the repository at this point in the history
  25. doc: add issue for news from ambassadors

    Signed-off-by: Michael Dawson <midawson@redhat.com>
    PR-URL: #53607
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    mhdawson authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    c997dbe View commit details
    Browse the repository at this point in the history
  26. doc: remove some news issues that are no longer

    Signed-off-by: Michael Dawson <midawson@redhat.com>
    PR-URL: #53608
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    mhdawson authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    5076f0d View commit details
    Browse the repository at this point in the history
  27. doc: fix doc for correct usage with plan & TestContext

    Fixed section in the doc that describes a test that uses the ⁠plan
    feature in the test-runner.
    However, the test in this example fails.
    The fix use  (Textcontext) and reduce the plan number
    to 1 since we have 1 assertion.
    
    PR-URL: #53615
    Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Emiltayeb authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    43ac5a2 View commit details
    Browse the repository at this point in the history
  28. tools: update lint-md-dependencies to unified@11.0.5

    PR-URL: #53555
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    nodejs-github-bot authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    0312065 View commit details
    Browse the repository at this point in the history
  29. test: do not assume cwd in snapshot tests

    PR-URL: #53146
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    aduh95 authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    662bf52 View commit details
    Browse the repository at this point in the history
  30. typings: add fs_dir types

    PR-URL: #53631
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
    Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    anonrig authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    2d8490f View commit details
    Browse the repository at this point in the history
  31. doc: fix module customization hook examples

    When running these examples, `node` fails to return as this
    `MessagePort` keeps the event loop active in the main thread unless
    it is `unref()`ed.
    
    Fixes: #52846
    PR-URL: #53637
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
    elliotgoodrich authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    e0d213d View commit details
    Browse the repository at this point in the history
  32. doc: include node.module_timer on available categories

    PR-URL: #53638
    Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    H4ad authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    758178b View commit details
    Browse the repository at this point in the history
  33. doc: mark NODE_MODULE_VERSION for Node.js 22.0.0

    PR-URL: #53650
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
    targos authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    4346de7 View commit details
    Browse the repository at this point in the history
  34. meta: bump step-security/harden-runner from 2.8.0 to 2.8.1

    Bumps [step-security/harden-runner](https://github.com/step-security/harden-runner) from 2.8.0 to 2.8.1.
    - [Release notes](https://github.com/step-security/harden-runner/releases)
    - [Commits](step-security/harden-runner@f086349...17d0e2b)
    
    ---
    updated-dependencies:
    - dependency-name: step-security/harden-runner
      dependency-type: direct:production
      update-type: version-update:semver-patch
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    PR-URL: #53670
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
    dependabot[bot] authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    5dcdfb5 View commit details
    Browse the repository at this point in the history
  35. meta: bump peter-evans/create-pull-request from 6.0.5 to 6.1.0

    Bumps [peter-evans/create-pull-request](https://github.com/peter-evans/create-pull-request) from 6.0.5 to 6.1.0.
    - [Release notes](https://github.com/peter-evans/create-pull-request/releases)
    - [Commits](peter-evans/create-pull-request@6d6857d...c5a7806)
    
    ---
    updated-dependencies:
    - dependency-name: peter-evans/create-pull-request
      dependency-type: direct:production
      update-type: version-update:semver-minor
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    PR-URL: #53671
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
    dependabot[bot] authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    bb6fe38 View commit details
    Browse the repository at this point in the history
  36. meta: bump actions/checkout from 4.1.6 to 4.1.7

    Bumps [actions/checkout](https://github.com/actions/checkout) from 4.1.6 to 4.1.7.
    - [Release notes](https://github.com/actions/checkout/releases)
    - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
    - [Commits](actions/checkout@a5ac7e5...692973e)
    
    ---
    updated-dependencies:
    - dependency-name: actions/checkout
      dependency-type: direct:production
      update-type: version-update:semver-patch
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    PR-URL: #53672
    Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    dependabot[bot] authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    39d6c78 View commit details
    Browse the repository at this point in the history
  37. meta: bump github/codeql-action from 3.25.7 to 3.25.11

    Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.25.7 to 3.25.11.
    - [Release notes](https://github.com/github/codeql-action/releases)
    - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
    - [Commits](github/codeql-action@f079b84...b611370)
    
    ---
    updated-dependencies:
    - dependency-name: github/codeql-action
      dependency-type: direct:production
      update-type: version-update:semver-patch
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    PR-URL: #53673
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
    dependabot[bot] authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    d5a9c24 View commit details
    Browse the repository at this point in the history
  38. meta: bump mozilla-actions/sccache-action from 0.0.4 to 0.0.5

    Bumps [mozilla-actions/sccache-action](https://github.com/mozilla-actions/sccache-action) from 0.0.4 to 0.0.5.
    - [Release notes](https://github.com/mozilla-actions/sccache-action/releases)
    - [Commits](Mozilla-Actions/sccache-action@2e7f9ec...89e9040)
    
    ---
    updated-dependencies:
    - dependency-name: mozilla-actions/sccache-action
      dependency-type: direct:production
      update-type: version-update:semver-patch
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    PR-URL: #53674
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
    dependabot[bot] authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    f84e215 View commit details
    Browse the repository at this point in the history
  39. meta: bump codecov/codecov-action from 4.4.1 to 4.5.0

    Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 4.4.1 to 4.5.0.
    - [Release notes](https://github.com/codecov/codecov-action/releases)
    - [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md)
    - [Commits](codecov/codecov-action@125fc84...e28ff12)
    
    ---
    updated-dependencies:
    - dependency-name: codecov/codecov-action
      dependency-type: direct:production
      update-type: version-update:semver-minor
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    PR-URL: #53675
    Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    dependabot[bot] authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    a5f5b45 View commit details
    Browse the repository at this point in the history
  40. test: use python3 instead of python in pummel test

    As f9bfe78 already did for a regular test, replace `python` with
    `python3` in the only `pummel` test spawning it so that it can be run on
    platforms that don't provide a `python` binary anymore, like modern
    macOS or some Linux distributions (e.g. Fedora) without specifying a
    `PYTHON` env var.
    
    PR-URL: #53057
    Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    fahrradflucht authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    6dc1898 View commit details
    Browse the repository at this point in the history
  41. meta: move regular TSC member to emeritus

    Signed-off-by: Michael Dawson <midawson@redhat.com>
    PR-URL: #53693
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    mhdawson authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    aa0c5c2 View commit details
    Browse the repository at this point in the history
  42. doc: add additional explanation to the wildcard section in permissions

    Co-authored-by: Rafael Gonzaga <rafael.nunu@hotmail.com>
    PR-URL: #53664
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
    2 people authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    754090c View commit details
    Browse the repository at this point in the history
  43. doc: require node:process in assert doc examples

    PR-URL: #53702
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
    Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
    mfdebian authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    3b632e1 View commit details
    Browse the repository at this point in the history
  44. test: un-set inspector-async-hook-setup-at-inspect-brk as flaky

    There was a commit that got merged that should have fixed the issue
    
    ref: #50222 (comment)
    PR-URL: #53692
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    abmusse authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    c2b0dcd View commit details
    Browse the repository at this point in the history
  45. build: fix mac build error of c-ares under GN

    PR-URL: #53687
    Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    zcbenz authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    5ec5e78 View commit details
    Browse the repository at this point in the history
  46. url: add missing documentation for URL.parse()

    PR-URL: #53733
    Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    anonrig authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    1d961fa View commit details
    Browse the repository at this point in the history
  47. doc: fix releases guide for recent Git versions

    PR-URL: #53709
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
    Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    targos authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    c3536cf View commit details
    Browse the repository at this point in the history
  48. doc: exclude voting and regular TSC from spotlight

    Signed-off-by: Michael Dawson <midawson@redhat.com>
    PR-URL: #53694
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Ruy Adorno <ruy@vlt.sh>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    mhdawson authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    60ee41d View commit details
    Browse the repository at this point in the history
  49. worker: allow copied NODE_OPTIONS in the env setting

    When the worker spawning code copies NODE_OPTIONS from process.env,
    previously we do a check again on the copied NODE_OPTIONS and throw
    if it contains per-process settings. This can be problematic
    if the end user starts the process with a NODE_OPTIONS and the
    worker is spawned by a third-party that tries to extend process.env
    with some overrides before passing them into the worker. This patch
    adds another exception that allows the per-process options in the
    NODE_OPTIONS passed to a worker if the NODE_OPTIONS is
    character-by-character equal to the parent NODE_OPTIONS.
    While some more intelligent filter can be useful too,
    this works good enough for the inheritance case, when the worker
    spawning code does not intend to modify NODE_OPTIONS.
    
    PR-URL: #53596
    Refs: #41103
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    joyeecheung authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    d6d0427 View commit details
    Browse the repository at this point in the history
  50. doc: remove the last <pre> tag

    PR-URL: #53741
    Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
    Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
    ovflowd authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    98d59aa View commit details
    Browse the repository at this point in the history
  51. deps: update c-ares to v1.32.0

    PR-URL: #53722
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
    nodejs-github-bot authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    4647e6b View commit details
    Browse the repository at this point in the history
  52. src: fix Worker termination when '--inspect-brk' is passed

    Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com>
    PR-URL: #53724
    Fixes: #53648
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
    daeyeon authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    ef5dabd View commit details
    Browse the repository at this point in the history
  53. crypto: avoid std::function

    Using a template type lets the compiler choose an appropriate type
    that likely is more efficient than std::function since the lambda
    expressions at the call sites do not capture any values from surrounding
    scopes.
    
    PR-URL: #53683
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Filip Skokan <panva.ip@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    tniessen authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    fa0e8d7 View commit details
    Browse the repository at this point in the history
  54. doc: mention v8.setFlagsFromString to pm

    PR-URL: #53731
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    RafaelGSS authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    229f7f8 View commit details
    Browse the repository at this point in the history
  55. src: zero-initialize data that are copied into the snapshot

    To prevent padding from making the snapshot unreproducible,
    zero-initialize the data that are copied into the snapshot
    so that the padding copied are all zeros. This is better
    than enlarging the enums to align the fields since it doesn't
    make the snapshot bigger than necessary, and it removes the
    need of using static assertions to ensure alignment.
    
    PR-URL: #53563
    Refs: #50983
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Daniel Lemire <daniel@lemire.me>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    joyeecheung authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    584beaa View commit details
    Browse the repository at this point in the history
  56. src: document the Node.js context embedder data

    PR-URL: #53611
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    joyeecheung authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    e6d735a View commit details
    Browse the repository at this point in the history
  57. cli: update node.1 to reflect Atom's sunset

    PR-URL: #53734
    Refs: https://github.blog/2022-06-08-sunsetting-atom/
    Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
    Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    RedYetiDev authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    820e6e1 View commit details
    Browse the repository at this point in the history
  58. deps: update minimatch to 9.0.5

    PR-URL: #53646
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
    Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    nodejs-github-bot authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    878e9a4 View commit details
    Browse the repository at this point in the history
  59. deps: update c-ares to v1.32.1

    PR-URL: #53753
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    nodejs-github-bot authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    832328e View commit details
    Browse the repository at this point in the history
  60. lib: remove path.resolve from permissions.js

    PR-URL: #53729
    Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
    Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
    Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    RafaelGSS authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    d012dd3 View commit details
    Browse the repository at this point in the history
  61. src: fix typo in node.h

    Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com>
    PR-URL: #53759
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
    Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
    daeyeon authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    8135f36 View commit details
    Browse the repository at this point in the history
  62. meta: use HTML entities in commit-queue comment

    PR-URL: #53744
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    RedYetiDev authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    0ad4b7c View commit details
    Browse the repository at this point in the history
  63. build: fix build warning of c-ares under GN build

    PR-URL: #53750
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
    zcbenz authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    04798fb View commit details
    Browse the repository at this point in the history
  64. meta: move one or more collaborators to emeritus

    PR-URL: #53758
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
    Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    nodejs-github-bot authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    b8d2bbc View commit details
    Browse the repository at this point in the history
  65. doc: update scroll-padding-top to 4rem

    PR-URL: #53662
    Reviewed-By: Claudio Wunder <cwunder@gnome.org>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    cloydlau authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    9804731 View commit details
    Browse the repository at this point in the history
  66. src: use Maybe<void> in node::crypto::error

    With recent versions of V8, it is not necessary to use Maybe<bool>
    anymore.
    
    PR-URL: #53766
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    tniessen authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    81cd84c View commit details
    Browse the repository at this point in the history
  67. doc: add option to have support me link

    Refs: nodejs/TSC#1552
    
    Signed-off-by: Michael Dawson <midawson@redhat.com>
    PR-URL: #53312
    Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Ruy Adorno <ruy@vlt.sh>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    mhdawson authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    51e736a View commit details
    Browse the repository at this point in the history
  68. deps: update googletest to 305e5a2

    PR-URL: #53157
    Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    nodejs-github-bot authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    c01ce60 View commit details
    Browse the repository at this point in the history
  69. deps: update googletest to 34ad51b

    PR-URL: #53157
    Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    nodejs-github-bot authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    2a2620e View commit details
    Browse the repository at this point in the history
  70. src: fix error handling in ExportJWKAsymmetricKey

    Because call sites check IsNothing() on the return value of
    ExportJWKAsymmetricKey() and ignore the boolean value if the return
    value is Just (i.e., not nothing), this function must return Nothing()
    instead of Just(false) when throwing a JavaScript error.
    
    PR-URL: #53767
    Reviewed-By: Filip Skokan <panva.ip@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    tniessen authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    0c24b91 View commit details
    Browse the repository at this point in the history
  71. util: fix crashing when emitting new Buffer() deprecation warning #53075

    
    
    PR-URL: #53089
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
    Reviewed-By: Tim Perry <pimterry@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Uzlopak authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    ce877c6 View commit details
    Browse the repository at this point in the history
  72. doc: clarify authenticity of plaintexts in update

    PR-URL: #53784
    Reviewed-By: Filip Skokan <panva.ip@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
    tniessen authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    f64db24 View commit details
    Browse the repository at this point in the history
  73. doc: use mock.callCount() in examples

    PR-URL: #53754
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Raz Luvaton <rluvaton@gmail.com>
    regseb authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    e71aa7e View commit details
    Browse the repository at this point in the history
  74. url: reduce unnecessary string copies

    PR-URL: #53628
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Daniel Lemire <daniel@lemire.me>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    anonrig authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    7fc45f5 View commit details
    Browse the repository at this point in the history
  75. doc: add Rafael to the last security release

    PR-URL: #53769
    Refs: nodejs-private/security-release#29
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
    Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    RafaelGSS authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    32ac80a View commit details
    Browse the repository at this point in the history
  76. deps: upgrade npm to 10.8.2

    PR-URL: #53799
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
    npm-cli-bot authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    2f66c7e View commit details
    Browse the repository at this point in the history
  77. stream: improve inspector ergonomics

    PR-URL: #53800
    Fixes: #53789
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
    Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
    benjamingr authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    56299f7 View commit details
    Browse the repository at this point in the history
  78. deps: update ada to 2.9.0

    PR-URL: #53748
    Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    nodejs-github-bot authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    a19b283 View commit details
    Browse the repository at this point in the history
  79. meta: add node_sqlite.c to PR label config

    PR-URL: #53797
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
    Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
    Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
    RedYetiDev authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    c2bb460 View commit details
    Browse the repository at this point in the history
  80. src: use Maybe<void> in ManagedEVPPKey

    With recent versions of V8, it is not necessary to use Maybe<bool>
    anymore. This changes member functions of ManagedEVPPKey to use
    Maybe<void> instead, as well as (transitive) dependencies.
    
    PR-URL: #53811
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    tniessen authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    1a4da22 View commit details
    Browse the repository at this point in the history
  81. meta: change email address of anonrig

    PR-URL: #53829
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
    anonrig authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    bff6995 View commit details
    Browse the repository at this point in the history
  82. url: fix typo

    PR-URL: #53827
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Kay-Yuan authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    325eae0 View commit details
    Browse the repository at this point in the history
  83. doc, meta: add PTAL to glossary

    PR-URL: #53770
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    RedYetiDev authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    3c5e593 View commit details
    Browse the repository at this point in the history
  84. meta: remove redudant logging from dep updaters

    PR-URL: #53783
    Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    RedYetiDev authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    e60b089 View commit details
    Browse the repository at this point in the history
  85. doc: move MylesBorins to emeritus

    It's been a great run but I simply don't have time anymore.
    
    So long, and Thanks for All the Packages
    
    PR-URL: #53760
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Stewart X Addison <sxa@redhat.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    MylesBorins authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    f87eed8 View commit details
    Browse the repository at this point in the history
  86. tls: add setKeyCert() to tls.Socket

    PR-URL: #53636
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Tim Perry <pimterry@gmail.com>
    mscdex authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    8660d48 View commit details
    Browse the repository at this point in the history
  87. test_runner: remove plan option from run()

    This commit removes the plan option to run(). I believe it was
    added by mistake. It is not documented, untested, and a test
    plan does not make sense in the context of run().
    
    This commit also fixes a minor formatting issue in a related
    fixture.
    
    Refs: #52860
    PR-URL: #53834
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    cjihrig authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    206c668 View commit details
    Browse the repository at this point in the history
  88. src: update outdated references to spec sections

    The exact section has changed in recent versions of ECMA-262, so fix the
    section number and explicitly mark the edition of the standard to avoid
    having to update it in the future.
    
    PR-URL: #53832
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
    tniessen authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    e352a4e View commit details
    Browse the repository at this point in the history
  89. src,test: further cleanup references to osx

    PR-URL: #53820
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    danielbayley authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    2eea850 View commit details
    Browse the repository at this point in the history
  90. tools: use v8_features.json to populate config.gypi

    PR-URL: #53749
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    zcbenz authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    642d5c5 View commit details
    Browse the repository at this point in the history
  91. deps: update simdutf to 5.3.0

    PR-URL: #53837
    Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    nodejs-github-bot authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    fa8f99d View commit details
    Browse the repository at this point in the history
  92. deps: update corepack to 0.29.2

    PR-URL: #53838
    Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    nodejs-github-bot authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    398f7ac View commit details
    Browse the repository at this point in the history
  93. tools: update lint-md-dependencies

    - `remark-preset-lint-node@5.1.0`
    - `rollup@4.18.1`
    
    PR-URL: #53840
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    nodejs-github-bot authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    4dedf2a View commit details
    Browse the repository at this point in the history
  94. deps: update minimatch to 10.0.1

    PR-URL: #53841
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    nodejs-github-bot authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    78f6b34 View commit details
    Browse the repository at this point in the history
  95. deps: update googletest to 4b21f1a

    PR-URL: #53842
    Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    nodejs-github-bot authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    8c8e368 View commit details
    Browse the repository at this point in the history
  96. build: disable test-asan workflow

    It is running on ubuntu-20.04, which will inevitably be removed from
    GitHub actions at some point. Attempts to upgrade it to ubuntu-22.04
    and ubuntu-24.04 have failed.
    
    It is now blocking V8 updates because of errors that happen only with
    the `test-asan` job.
    
    Refs: #52374
    Refs: #53651 (comment)
    PR-URL: #53844
    Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    targos authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    977af25 View commit details
    Browse the repository at this point in the history
  97. src,lib: expose getCategoryEnabledBuffer to use on node.http

    Instead call the C++ code every time we need to check for a
    trace category, now we get the C++ pointer to the flag that
    holds the info if the trace is enabled and return this pointer
    inside a buffer that we can use to call/check if the value is
    enabled. With this change, no C++ call is made and the access
    to the info happens in JS side, which has no perf penalty.
    
    PR-URL: #53602
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    H4ad authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    31fdb88 View commit details
    Browse the repository at this point in the history
  98. src: fix env-file flag to ignore spaces before quotes

    Fix to ignore spaces between '=' and quoted string in env file
    
    Fixes: #53461
    
    Signed-off-by: Mohit Malhotra <dev.mohitmalhotra@gmail.com>
    PR-URL: #53786
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    MOHIT51196 authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    aff9a53 View commit details
    Browse the repository at this point in the history
  99. doc: update release-post nodejs.org script

    PR-URL: #53762
    Refs: nodejs/nodejs.org#6850
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    RafaelGSS authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    9224e3e View commit details
    Browse the repository at this point in the history
  100. doc: fix casing of GitHub handle for two collaborators

    PR-URL: #53857
    Reviewed-By: Nitzan Uziely <linkgoron@gmail.com>
    Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    aduh95 authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    f5280dd View commit details
    Browse the repository at this point in the history
  101. meta: move anonrig to tsc voting members

    PR-URL: #53888
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Paolo Insogna <paolo@cowtech.it>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Ruy Adorno <ruy@vlt.sh>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    anonrig authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    c0b24e5 View commit details
    Browse the repository at this point in the history
  102. doc: add MattiasBuelens to collaborators

    PR-URL: #53895
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    MattiasBuelens authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    44a1cbe View commit details
    Browse the repository at this point in the history
  103. cli: document --inspect port 0 behavior

    PR-URL: #53782
    Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
    RedYetiDev authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    137a2e5 View commit details
    Browse the repository at this point in the history
  104. lib: decorate async stack trace in source maps

    Decorate stack frame with 'async' and 'new' keywords based on the type
    of the call site info.
    
    PR-URL: #53860
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    legendecas authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    51ba566 View commit details
    Browse the repository at this point in the history
  105. src: replace ToLocalChecked uses with ToLocal in node-file

    PR-URL: #53869
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
    Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    jasnell authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    b71250a View commit details
    Browse the repository at this point in the history
  106. doc: update api_assets README for new files

    PR-URL: #53676
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Claudio Wunder <cwunder@gnome.org>
    RedYetiDev authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    233aba9 View commit details
    Browse the repository at this point in the history
  107. doc,tty: add documentation for ReadStream and WriteStream

    Co-authored-by: Qingyu Deng <i@ayase-lab.com>
    PR-URL: #53567
    Fixes: #37780
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Raz Luvaton <rluvaton@gmail.com>
    Reviewed-By: Claudio Wunder <cwunder@gnome.org>
    2 people authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    3cdf94d View commit details
    Browse the repository at this point in the history
  108. build,tools: simplify upload of shasum signatures

    Use the same prompt for uploads to the web host and Cloudflare R2.
    
    PR-URL: #53892
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    targos authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    a2d74f4 View commit details
    Browse the repository at this point in the history
  109. lib: improve error message when index not found on cjs

    PR-URL: #53859
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
    H4ad authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    c667fbd View commit details
    Browse the repository at this point in the history
  110. test: deflake test-blob-file-backed

    Avoid race conditions by using a different file for each subtest.
    
    Fixes: #51860
    PR-URL: #53920
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    lpinca authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    be94e47 View commit details
    Browse the repository at this point in the history
  111. doc: move --test-coverage-{ex,in}clude to proper location

    This commit moves the documentation for two CLI flags to the
    proper sorted location.
    
    PR-URL: #53926
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    cjihrig authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    139c62e View commit details
    Browse the repository at this point in the history
  112. build: update codecov coverage build count

    PR-URL: #53929
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    anonrig authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    5727b4d View commit details
    Browse the repository at this point in the history
  113. build: trigger coverage ci when updating codecov

    PR-URL: #53929
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    anonrig authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    342a663 View commit details
    Browse the repository at this point in the history
  114. meta: store actions secrets in environment

    PR-URL: #53930
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    RedYetiDev authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    1864cdd View commit details
    Browse the repository at this point in the history
  115. doc: remove scroll-behavior: smooth;

    PR-URL: #53942
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    cloydlau authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    89599e0 View commit details
    Browse the repository at this point in the history
  116. test: use PYTHON executable from env in assertSnapshot

    PR-URL: #53938
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    aduh95 authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    edb75ae View commit details
    Browse the repository at this point in the history
  117. test: reduce flakiness of test-assert-esm-cjs-message-verify

    PR-URL: #53967
    Fixes: #53962
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
    Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    aduh95 authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    6d0b8de View commit details
    Browse the repository at this point in the history
  118. doc: add info about prefix-only modules to module.builtinModules

    PR-URL: #53954
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    SunsetTechuila authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    a3183fb View commit details
    Browse the repository at this point in the history
  119. tools: fix SLACK_TITLE in invalid commit workflow

    PR-URL: #53912
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    aduh95 authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    9c5beab View commit details
    Browse the repository at this point in the history
  120. child_process: fix incomplete prototype pollution hardening

    Prior pull request (#48726) hardened against prototype pollution
    vulnerabilities but effectively missed some use-cases which
    opened a window for prototype pollution for some child_process
    functions such as spawn(), spawnSync(), and execFileSync().
    
    PR-URL: #53781
    Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    lirantal authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    993bb3b View commit details
    Browse the repository at this point in the history
  121. lib: improve cluster/primary code

    PR-URL: #53756
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    ehsankhfr authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    a4ff2ac View commit details
    Browse the repository at this point in the history
  122. doc: update boxstarter README

    PR-URL: #53785
    Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    RedYetiDev authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    25e59ae View commit details
    Browse the repository at this point in the history
  123. src: avoid strcmp in ImportJWKAsymmetricKey

    Use std::string_view and its operator== instead of calling strcmp on a
    const char*.
    
    PR-URL: #53813
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    tniessen authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    acaf5dd View commit details
    Browse the repository at this point in the history
  124. src: cache invariant code motion

    PR-URL: #53879
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Paolo Insogna <paolo@cowtech.it>
    Reviewed-By: Tim Perry <pimterry@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
    RafaelGSS authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    848c2d5 View commit details
    Browse the repository at this point in the history
  125. test: skip --title check on IBM i

    Similar to SmartOS IBM i does not return the process.title
    
    PR-URL: #53952
    Fixes: #53852
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    abmusse authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    56c26fe View commit details
    Browse the repository at this point in the history
  126. meta: make more bug-report information required

    PR-URL: #53718
    Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    RedYetiDev authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    e6ba121 View commit details
    Browse the repository at this point in the history
  127. build, tools: drop leading / from r2dir

    The script is commented as removing `/home/dist/` part but the `cut`
    command is off by one and end up including the `/` character (so that
    the resulting string starts with `/`). When this is substituted into
    `s3://${cloudflare_bucket}/${r2dir}/${shafile}.asc` we end up with
    `//` (one from the template and one from the `r2dir`) which appears
    to cause Cloudflare to create an extra top level `/` directory in the
    bucket.
    
    PR-URL: #53951
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    richardlau authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    ffb0bd3 View commit details
    Browse the repository at this point in the history
  128. meta: remove license for hljs

    PR-URL: #53970
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
    RedYetiDev authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    6ca0cfc View commit details
    Browse the repository at this point in the history
  129. src: fix slice of slice of file-backed Blob

    The value for `new_end` was wrong: While the members `start_` and `end_`
    refer to the entire length of the file, the parameters `start` and `end`
    are relative to the current slice.
    
    The new end would apparently have the current start_ subtracted from it,
    and the length would possibly overflow when the FdEntry is asked for its
    size or when get_reader is called, resulting in a subslice which extends
    past the current slice, which shouldn't be possible. Add a CHECK if this
    happens, rather than returning data outside the current slice.
    
    There aren't any C++ tests for FdEntry, and on the javascript side there
    isn't a way to ask the blob handle for its nominal size. That size could
    be a large uint64, which gets converted to int64 to when FileHandle::new
    is called, which interprets a negative length as unlimited.
    
    Fixes: #53908
    PR-URL: #53972
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    jleedev authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    4c36d6c View commit details
    Browse the repository at this point in the history
  130. test: skip sea tests in large debug builds

    In debug builds, the node binary could exceed 2GB and can not be read by
    postject.
    
    PR-URL: #53918
    Refs: nodejs/reliability#922
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    legendecas authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    2e69e5f View commit details
    Browse the repository at this point in the history
  131. test_runner: cleanup global event listeners after run

    PR-URL: #53878
    Fixes: #53868
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    EddieAbbondanzio authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    367f9e7 View commit details
    Browse the repository at this point in the history
  132. doc: fix typo in recognizing-contributors

    PR-URL: #53990
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    ead05aa View commit details
    Browse the repository at this point in the history
  133. process: unify experimental warning messages

    PR-URL: #53704
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
    Reviewed-By: Filip Skokan <panva.ip@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    RedYetiDev authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    bf6aa53 View commit details
    Browse the repository at this point in the history
  134. fs: ensure consistency for mkdtemp in both fs and fs/promises

    Port changes for mkdtemp from lib/fs.js to lib/internal/fs/promise.js,
    ensuring consistent behavior.
    
    Refs: #51078
    PR-URL: #53776
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: LiviaMedeiros <livia@cirno.name>
    YieldRay authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    490f15a View commit details
    Browse the repository at this point in the history
  135. test: compare paths on Windows without considering case

    PR-URL: #53993
    Fixes: #53989
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    EarlyRiser42 authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    f2b4fd3 View commit details
    Browse the repository at this point in the history
  136. test: mark test-pipe-file-to-http as flaky

    PR-URL: #53751
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    jakecastelli authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    0ad783c View commit details
    Browse the repository at this point in the history
  137. meta: add jake to collaborators

    Fixes: #53777
    PR-URL: #54004
    Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    jakecastelli authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    ae30674 View commit details
    Browse the repository at this point in the history
  138. src: fix -Wshadow warning

    PR-URL: #53885
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    codebytere authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    6bafe8a View commit details
    Browse the repository at this point in the history
  139. build: ensure v8_pointer_compression_sandbox is enabled on 64bit

    PR-URL: #53884
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    codebytere authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    a9c04ea View commit details
    Browse the repository at this point in the history
  140. deps: update c-ares to v1.32.2

    PR-URL: #53865
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    nodejs-github-bot authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    5eea419 View commit details
    Browse the repository at this point in the history
  141. doc, test: tracing channel hasSubscribers getter

    follow up work for #51915
    
    PR-URL: #52908
    Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    tlhunter authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    f336e61 View commit details
    Browse the repository at this point in the history
  142. meta: move tsc member to emeritus

    Based on TSC discussion.
    
    Signed-off-by: Michael Dawson <midawson@redhat.com>
    PR-URL: #54029
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
    mhdawson authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    bfabfb4 View commit details
    Browse the repository at this point in the history
  143. lib: optimize copyError with ObjectAssign in primordials

    optimized the copyError function by using ObjectAssign from primordials.
    this change replaces the for-loop with ObjectAssign, which improves
    memory usage and performance.
    
    this change updates the copyError function in internal/assert.js to
    use ObjectAssign for copying properties.
    
    PR-URL: #53999
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
    rayark1 authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    0d70c79 View commit details
    Browse the repository at this point in the history
  144. test: mark 'test/parallel/test-sqlite.js' as flaky

    The current test is large and can time out. It should be split
    into multiple smaller tests as done in #54014. However, that
    approach appears to change GC behavior such that the database
    files are not cleaned up quickly enough on Windows. Forcing
    any unfinalized SQL statements to be GC'ed appears to fix the
    problem. Mark the original test as flaky until the necessary
    code changes are made.
    
    PR-URL: #54031
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
    Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    cjihrig authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    43ede1a View commit details
    Browse the repository at this point in the history
  145. src: simplify AESCipherTraits::AdditionalConfig

    Instead of a giant switch statement and a lot of duplicate code, add the
    NID and the block cipher mode of operation to the VARIANTS list and use
    those fields to perform configuration appropriately.
    
    PR-URL: #53890
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    tniessen authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    0109f9c View commit details
    Browse the repository at this point in the history
  146. test_runner: do not throw on mocked clearTimeout()

    PR-URL: #54005
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
    Aksinya-Bykova authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    fb73422 View commit details
    Browse the repository at this point in the history
  147. test: add test for one arg timers to increase coverage

    PR-URL: #54007
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Ceres6 authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    5c5093d View commit details
    Browse the repository at this point in the history
  148. test: add comments and rename test for timer robustness

    The name of the test did not make it clear what it was about. (It also
    used "timer" in the name instead of "timers" like all the other tests.)
    I also added a comment to be extra clear about the test purpose and a
    link to the issue that was originally filed about it.
    
    PR-URL: #54008
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
    Trott authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    364d09c View commit details
    Browse the repository at this point in the history
  149. doc: move GeoffreyBooth to TSC regular member

    PR-URL: #54047
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    GeoffreyBooth authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    6a5120f View commit details
    Browse the repository at this point in the history
  150. stream: expose DuplexPair API

    PR-URL: #34111
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    awwright authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    7c21bb9 View commit details
    Browse the repository at this point in the history
  151. test: remove unnecessary console log

    PR-URL: #53812
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
    Kay-Yuan authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    9a98ad4 View commit details
    Browse the repository at this point in the history
  152. deps: update c-ares to v1.32.3

    PR-URL: #54020
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    nodejs-github-bot authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    496975e View commit details
    Browse the repository at this point in the history
  153. node-api: rename nogc to basic

    Signed-off-by: Gabriel Schulhof <gabrielschulhof@gmail.com>
    PR-URL: #53830
    Reviewed-By: Vladimir Morozov <vmorozov@microsoft.com>
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    gabrielschulhof authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    e6a4104 View commit details
    Browse the repository at this point in the history
  154. test: skip sea tests with more accurate available disk space estimation

    PR-URL: #53996
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    legendecas authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    bec88ce View commit details
    Browse the repository at this point in the history
  155. meta: add sqlite to js subsystems

    PR-URL: #53911
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
    himself65 authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    e326342 View commit details
    Browse the repository at this point in the history
  156. test: move shared module to test/common

    `test/fixtures/process-exit-code-cases.js` is a shared module and should
    be in `test/common` (so it gets linted, etc.) and documented in
    `test/common/README.md`.
    
    PR-URL: #54042
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Trott authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    77761af View commit details
    Browse the repository at this point in the history
  157. build: update gcovr to 7.2 and codecov config

    PR-URL: #54019
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    bcoe authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    61b90e7 View commit details
    Browse the repository at this point in the history
  158. test_runner: switched to internal readline interface

    Switched to using internal interface after
    
    PR-URL: #54000
    Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Emiltayeb authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    c0262c1 View commit details
    Browse the repository at this point in the history
  159. http: add diagnostics channel http.client.request.error

    PR-URL: #54054
    Reviewed-By: Paolo Insogna <paolo@cowtech.it>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
    Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
    cola119 authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    8e64c02 View commit details
    Browse the repository at this point in the history
  160. assert: use isError instead of instanceof in innerOk

    Co-Authored-By: Ruben Bridgewater <ruben@bridgewater.de>
    Co-Authored-By: Nihar Phansalkar <phansalkarnihar@gmail.com>
    PR-URL: #53980
    Fixes: #50780
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
    3 people authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    b3a2726 View commit details
    Browse the repository at this point in the history
  161. doc: fix typo in diagnostic tooling support tiers document

    PR-URL: #54058
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    kimtaejin3 authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    1c0ccc0 View commit details
    Browse the repository at this point in the history
  162. doc: fix typo in technical-priorities.md

    added a space between the two words.
    
    PR-URL: #54094
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
    MCprotein authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    55f5e76 View commit details
    Browse the repository at this point in the history
  163. node-api: add property keys benchmark

    PR-URL: #54012
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    legendecas authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    ac58c82 View commit details
    Browse the repository at this point in the history
  164. doc: update security-release process to automated one

    PR-URL: #53877
    Refs: nodejs/security-wg#860
    Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    RafaelGSS authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    36170ed View commit details
    Browse the repository at this point in the history
  165. src: expose LookupAndCompile with parameters

    PR-URL: #53886
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    codebytere authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    2a3ae16 View commit details
    Browse the repository at this point in the history
  166. test: do not swallow uncaughtException errors in exit code tests

    PR-URL: #54039
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    nektro authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    bd996bf View commit details
    Browse the repository at this point in the history
  167. doc: move numCPUs require to top of file in cluster CJS example

    PR-URL: #53932
    Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    mfdebian authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    30310bf View commit details
    Browse the repository at this point in the history
  168. deps: update corepack to 0.29.3

    PR-URL: #54072
    Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
    nodejs-github-bot authored and marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    44268c2 View commit details
    Browse the repository at this point in the history
  169. 2024-08-21, Version 20.17.0 'Iron' (LTS)

    Notable changes:
    
    http:
      * (SEMVER-MINOR) add diagnostics channel `http.client.request.error` (Kohei Ueno) #54054
    meta:
      * add jake to collaborators (jakecastelli) #54004
    module:
      * (SEMVER-MINOR) support require()ing synchronous ESM graphs (Joyee Cheung) #51977
    path:
      * (SEMVER-MINOR) add `matchesGlob` method (Aviv Keller) #52881
    stream:
      * (SEMVER-MINOR) expose DuplexPair API (Austin Wright) #34111
      * (SEMVER-MINOR) implement `min` option for `ReadableStreamBYOBReader.read` (Mattias Buelens) #50888
    
    PR-URL: #54447
    marco-ippolito committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    efbec04 View commit details
    Browse the repository at this point in the history