Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: switch from Get/SetPrototype to Get/SetPrototypeV2 #55453

Merged
merged 2 commits into from
Oct 22, 2024
Merged

src: switch from Get/SetPrototype to Get/SetPrototypeV2 #55453

merged 2 commits into from
Oct 22, 2024

Conversation

RedYetiDev
Copy link
Member

Ref #55452

GetPrototype has been deprecated in favor of GetPrototypeV2. See https://issues.chromium.org/issues/333672197

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/node-api

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. node-api Issues and PRs related to the Node-API. labels Oct 18, 2024
@RedYetiDev RedYetiDev mentioned this pull request Oct 18, 2024
Open
7 tasks
@RedYetiDev RedYetiDev changed the title src: switch from GetPrototype to GetPrototypeV2 src: switch from Get/SetPrototype to Get/SetPrototypeV2 Oct 18, 2024
@RedYetiDev RedYetiDev added lib / src Issues and PRs related to general changes in the lib or src directory. and removed node-api Issues and PRs related to the Node-API. labels Oct 18, 2024
vmoroz
vmoroz approved these changes Oct 18, 2024
View reviewed changes
Copy link
Member

@vmoroz vmoroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RedYetiDev RedYetiDev added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Oct 18, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 18, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/63195/

@codecov Codecov
Copy link

codecov bot commented Oct 19, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 45.00000% with 11 lines in your changes missing coverage. Please review.

Project coverage is 88.41%. Comparing base (7ae193d) to head (5d3c0bb).
Report is 28 commits behind head on main.

Files with missing lines Patch % Lines
src/node_constants.cc 0.00% 0 Missing and 10 partials ⚠️
src/api/environment.cc 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #55453   +/-   ##
=======================================
  Coverage   88.40%   88.41%           
=======================================
  Files         653      653           
  Lines      187600   187507   -93     
  Branches    36117    36104   -13     
=======================================
- Hits       165854   165784   -70     
+ Misses      14974    14959   -15     
+ Partials     6772     6764    -8
Files with missing lines Coverage Δ
src/internal_only_v8.cc 80.00% <100.00%> (ø)
src/js_native_api_v8.cc 76.51% <100.00%> (ø)
src/node_buffer.cc 70.36% <100.00%> (-0.21%) ⬇️
src/node_options.cc 87.44% <100.00%> (+0.03%) ⬆️
src/node_webstorage.cc 72.20% <100.00%> (ø)
src/api/environment.cc 75.81% <0.00%> (-0.20%) ⬇️
src/node_constants.cc 97.05% <0.00%> (ø)

... and 34 files with indirect coverage changes

jasnell
jasnell approved these changes Oct 20, 2024
View reviewed changes
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be noted that v8 may end up renaming this back to SetPrototype and GetPrototype later once the original version is removed.

@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 22, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 22, 2024
@nodejs-github-bot nodejs-github-bot merged commit e4ca097 into nodejs:main Oct 22, 2024
63 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in e4ca097

aduh95 pushed a commit that referenced this pull request Oct 23, 2024
@RedYetiDev @aduh95
src: switch from Get/SetPrototype to Get/SetPrototypeV2
cc775d3 
PR-URL: #55453
Reviewed-By: Vladimir Morozov <vmorozov@microsoft.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: James M Snell <jasnell@gmail.com>
@aduh95 aduh95 mentioned this pull request Oct 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NickNaso NickNaso NickNaso approved these changes

@jasnell jasnell jasnell approved these changes

@vmoroz vmoroz vmoroz approved these changes

@anonrig anonrig anonrig approved these changes

@MoLow MoLow MoLow approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@RedYetiDev @nodejs-github-bot @NickNaso @jasnell @vmoroz @anonrig @MoLow @aduh95