-
Notifications
You must be signed in to change notification settings - Fork 29.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
src: migrate String::Value
to String::ValueView
#55458
base: main
Are you sure you want to change the base?
Conversation
67d7fcd
to
fdc94c9
Compare
I've added
needs-benchmark-ci
I've also added
needs-citgm
|
String::Value
to String::ValueView
String::Value
to String::ValueView
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #55458 +/- ##
=======================================
Coverage 88.41% 88.41%
=======================================
Files 653 653
Lines 187485 187429 -56
Branches 36095 36070 -25
=======================================
- Hits 165764 165717 -47
+ Misses 14966 14950 -16
- Partials 6755 6762 +7
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I'm gonna hold off on a CI until the GitHub builds pass, because there might be failures that are already evident |
Hey, can someone start a benchmark CI and CITGM? The sooner these are done the sooner this can land :-) |
Please don't do that, the label is there to inform the bot this PR requires passing Jenkins CI to land
What benchmark would we run? |
That was an accident 😅, I don't even remember doing that.
I was thinking Buffer (for the indexOf), and string_bytes (if we have one) |
Fixes #54417
Ref: #55452
v8::String::Value
is deprecated, so this PR replaces it withv8::String::ValueView