tools: update gyp-next to 0.18.3 #55464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
gyp
|
Review requested:
|
nodejs-github-bot
added
build
RafaelGSS
approved these changes
Oct 20, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #55464 +/- ##
=======================================
Coverage 88.41% 88.42%
=======================================
Files 653 653
Lines 187513 187513
Branches 36096 36104 +8
=======================================
+ Hits 165791 165805 +14
+ Misses 14961 14950 -11
+ Partials 6761 6758 -3 |
|
Does this even need a CI? It's only doc changes on our end. |
legendecas
approved these changes
Oct 21, 2024
|
I think it is not necessary but our tools will complain on it if CI did not run. |
github-actions
bot
removed
the
request-ci
richardlau
added
the
commit-queue
If anyone is wondering, gyp-next@0.18.3 was not a doc-only update -- it includes the upstream version of #55249 but since that was already applied here it's not showing up in this PR. |
richardlau
approved these changes
Oct 22, 2024
nodejs-github-bot
removed
the
commit-queue
|
Landed in a3693d2 |
aduh95
pushed a commit
that referenced
this pull request
Oct 23, 2024
PR-URL: #55464 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated update of gyp-next to 0.18.3.