Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: update --max-semi-space-size description in cli.md #55495

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

doc: update --max-semi-space-size description in cli.md #55495

wants to merge 1 commit into from
+6 −2

Conversation

joebowbeer
Copy link

Fixes #55487

@nodejs-github-bot nodejs-github-bot added cli Issues and PRs related to the Node.js command line interface. doc Issues and PRs related to the documentations. labels Oct 22, 2024
This was referenced Oct 22, 2024
Open
Open
RedYetiDev
RedYetiDev reviewed Oct 23, 2024
View reviewed changes
doc/api/cli.md Outdated Show resolved Hide resolved
@RedYetiDev RedYetiDev added the dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. label Oct 23, 2024
@RedYetiDev
Copy link
Member

RedYetiDev commented Oct 23, 2024 •
edited
Loading

Please amend your commit message to follow the guidelines of commits in this repo. Something similar to your PR title will work.

Congrats on your first contribution 🎉

@joebowbeer
Copy link
Author

@RedYetiDev I addressed both of your comments.

@joebowbeer
Copy link
Author

Should I lowercase the commit title?

@lpinca
Copy link
Member

lpinca commented Oct 23, 2024

Yes, Update -> update.

@joebowbeer
Copy link
Author

@lpinca addressed

@joebowbeer joebowbeer changed the title doc: Update --max-semi-space-size description in cli.md doc: update --max-semi-space-size description in cli.md Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@RedYetiDev RedYetiDev Awaiting requested review from RedYetiDev

Assignees
No one assigned
Labels
cli Issues and PRs related to the Node.js command line interface. doc Issues and PRs related to the documentations. dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

--max-semi-space-size doc is wrong after Node 18
4 participants
@joebowbeer @RedYetiDev @lpinca @nodejs-github-bot