Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

module: fix error thrown from require(esm) hitting TLA repeatedly #55520

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

module: fix error thrown from require(esm) hitting TLA repeatedly #55520

wants to merge 1 commit into from
+40 −10

Commits on Oct 24, 2024

  1. module: fix error thrown from require(esm) hitting TLA repeatedly 

    This tracks the asynchronicity in the ModuleWraps when they turn out to
contain TLA after instantiation, and throw the right error
(ERR_REQUIRE_ASYNC_MODULE) when it's required again. It removes
the freezing of ModuleWraps since it's not meaningful to freeze
this when the rest of the module loader is mutable, and we
can record the asynchronicity in the ModuleWrap right after
compilation after we get a V8 upgrade that contains
v8::Module::HasTopLevelAwait() instead of searching through
the module graph repeatedly which can be slow.
    @joyeecheung
    joyeecheung committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    f1ffcc3 View commit details
    Browse the repository at this point in the history