Skip to content

Conversation

@richardlau
Copy link
Member

Addresses the lint warnings:

Items in `changes` list are not in order nodejs-yaml-comments

Refs: #58849


node-test-linter is failing for main,
e.g. https://ci.nodejs.org/job/node-test-linter/62229/console

08:10:40 Running Markdown linter...
08:10:40 doc/api/assert.md
08:10:40 342:1-402:4 warning Items in `changes` list are not in order nodejs-yaml-comments remark-lint
08:10:40 545:1-597:4 warning Items in `changes` list are not in order nodejs-yaml-comments remark-lint
08:12:59 
08:12:59 ⚠ 2 warnings
08:12:59 make: *** [Makefile:1392: tools/.mdlintstamp] Error 1

The new entries in #58849 should have been placed at the top of the changes list, but it didn't fail the linter there because the entries above it had the same REPLACEME version holder as they had not yet been released (is this fixable in the lint rule?). Now that the other changes have landed in Node.js 25.0.0 their version has been changed to v25.0.0 which means that the entries for #58849 are now out of order.

Addresses the lint warnings:
```
Items in `changes` list are not in order nodejs-yaml-comments
```
@nodejs-github-bot nodejs-github-bot added assert Issues and PRs related to the assert subsystem. doc Issues and PRs related to the documentations. labels Oct 18, 2025
@richardlau
Copy link
Member Author

Duplicate of #60304

@richardlau richardlau marked this as a duplicate of #60304 Oct 18, 2025
@richardlau richardlau closed this Oct 18, 2025
@richardlau richardlau deleted the lintfix branch October 18, 2025 13:13
@richardlau richardlau added the duplicate Issues and PRs that are duplicates of other issues or PRs. label Oct 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

assert Issues and PRs related to the assert subsystem. doc Issues and PRs related to the documentations. duplicate Issues and PRs that are duplicates of other issues or PRs.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants