-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(learn): Collecting code coverage #7006
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This is currently marked as draft until the next semver-minor release of Node.js |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is my first feedback, I think the introduction should be improved to put it in context. It should be remembered that the learn section is intended for non-experts.
apps/site/pages/en/learn/test-runner/collecting-code-coverage.md
Outdated
Show resolved
Hide resolved
apps/site/pages/en/learn/test-runner/collecting-code-coverage.md
Outdated
Show resolved
Hide resolved
apps/site/pages/en/learn/test-runner/collecting-code-coverage.md
Outdated
Show resolved
Hide resolved
apps/site/pages/en/learn/test-runner/collecting-code-coverage.md
Outdated
Show resolved
Hide resolved
apps/site/pages/en/learn/test-runner/collecting-code-coverage.md
Outdated
Show resolved
Hide resolved
apps/site/pages/en/learn/test-runner/collecting-code-coverage.md
Outdated
Show resolved
Hide resolved
apps/site/pages/en/learn/test-runner/collecting-code-coverage.md
Outdated
Show resolved
Hide resolved
ee241d0
to
f26b449
Compare
Deployment failed with the following error:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
apps/site/pages/en/learn/test-runner/collecting-code-coverage.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for writing this, reads well
apps/site/pages/en/learn/test-runner/collecting-code-coverage.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Michael Esteban <mickel13@gmail.com> Signed-off-by: Aviv Keller <38299977+RedYetiDev@users.noreply.github.com>
I've undrafted this, as the release proposal for v22.8.0 is ready at nodejs/node#54560, but it still shouldn't land until that does. The expected release date is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is great - looking forward to it
Can we have last review form @nodejs/test_runner |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is amazing. However I'm not sure we should be landing this before having stabilized the code coverage functionality.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is amazing. However I'm not sure we should be landing this before having stabilized the code coverage functionality.
I think this is okay to land once v22.8.0 releases, as it specifies that the |
I think it's better to hold off until it's stable. |
Signed-off-by: Aviv Keller <redyetidev@gmail.com>
Is there an ETA for the stabilization of it? |
IMO code coverage (w/o the I asked a few weeks ago, and it was pointed out that statement coverage isn't supported, however, I'm not sure if that's in the plans for the immediate future of code coverage. The original issue tracking the stability has been closed as completed, as all tasks were completed, which might mean it's ready to be stable. I've left a comment asking. |
I'm fine keeping this open for the meantime, the problem is it becoming stale. |
I'm also happy to close and reopen it, as chances are there will be some significant changes to the coverage reporter before stabilization, and this only collecting merge conflicts. |
Description
This PR introduces a learning article on collecting code coverage in Node.js. However, it should not be merged until support for thresholds is included in the next semver-minor release, which is expected to be next week.
Related Issues
Support for code coverage: nodejs/node#46017
Support for code coverage inclusion/exclusion: nodejs/node#53553
Support for code coverage thresholds: nodejs/node#54429
Check List
npm run format
to ensure the code follows the style guide.npm run test
to check if all tests are passing.npx turbo build
to check if the website builds without errors.