-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add streams guide #7123
feat: add streams guide #7123
Conversation
Co-authored-by: Matteo Collina <matteo.collina@gmail.com>
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
I'm missing translation for the titles as I didn't want to use translator ones |
You mustn't touch to translation fille it's handle with crowdin |
So should I remove the |
I mean you just have to update |
Can you please add a sentence at the beginning or end saying that this guide is a derivative of https://blog.platformatic.dev/a-guide-to-reading-and-writing-nodejs-streams? |
@mcollina do we want any corporate references to material that lands on the Node.js website? Asking because, in a similar vein, the article was reviewed by multiple people at Nearform, including myself, and we weren't going to ask @Ceres6 to attribute us. On the other hand, we were considering to publish the very same article on our company's blog, with a reference to the official documentation, as the authoring has in practice being supported by us. |
@simoneb You can see there are very few original contributions to what has been added here compared to what I wrote in the article, as multiple paragraphs were taken verbatim, including the whole of the introduction. By all intents and purposes, I'm the primary author of this PR, and I gave permission to use my original piece if I was included as a co-author of it and kindly asked for a backlink if possible. Adding a backlink is not unreasonable to ask. It's also ok if it's not added, but I would prefer it.
I think the question for the @nodejs/tsc is:
(We should not be using existing material without the author permission anyway). |
Here is a proposal, how about you include in the commit description:
So we keep a record of the origin of this content. |
@mcollina I'm happy to add the backlink. I'm guessing now the TSC is tagged we should wait until that gets discussed, right? EDIT: I saw that some resources in the learn section have an authors frontmatter prop, maybe that's another option to consider? |
I think it's good if the TSC discuss this because I suspect it would come out more and more. @Ceres6 you should definitely fill in the |
Cool! I'll add authors then and wait for the TSC discussion on the backlink. Just one doubt, should I add Nearform reviewers as authors or are those not considered as such? @mcollina |
I would list them all. |
Hey folks 👋 are we happy here? |
Lighthouse Results
|
As far as I can see there were only opinions in favour of adding them, not sure if there should be a formal ruling or something |
Co-authored-by: Aviv Keller <redyetidev@gmail.com> Signed-off-by: Carlos Espa <43477095+Ceres6@users.noreply.github.com>
It'll be discussed at every-ish meeting while it's on the agenda. Once they remove the label, they should come to a formal dicision. (Also BTW this isn't the first time we've reposted external content with permission, see nodejs.org/apps/site/pages/en/blog/module/multi-server-continuous-deployment-with-fleet.md Line 9 in 83081ef
|
@mcollina did you have time to review it? |
Hey folks, this has been here for a couple of months, can we try to move it forward? It's just a guide to be added to the docs. I believe we agreed that we're going to credit @mcollina and Platformatic explicitly in the content, and myself and @codyzu in the markdown metadata. I'm happy with that, so unless anybody disagrees, I would suggest to move this forward. |
Hey there, we can only move forward with explicit approval from the TSC. Hence we gotta wait for @mcollina |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sorry about the wait, I had a significant build-up of OSS work to crunch. |
So can we move this forward @ovflowd? |
Did you address @styfle's comment? 👀 |
(I cannot merge until all discussions are resolved) -- hence you can either ignore his suggestion or address it 🙏 |
I answered the comment, we can always revisit, but I think it's good to go |
Description
This PR adds a stream guide for the learn section
Validation
Lint passing and checked visually
Related Issues
Closes nodejs/node#8646
Check List
npm run format
to ensure the code follows the style guide.npm run test
to check if all tests are passing.npx turbo build
to check if the website builds without errors.