content: add promises example to accepting input from the command line #7252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Benson Isaac <159860495+heybosi@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
avivkeller
requested changes
Nov 20, 2024
avivkeller
changed the title
avivkeller
reviewed
Nov 20, 2024
Comment on lines
+50
to
+53
| rl.close() | ||
|
|
||
| console.log(`Hi ${name}!`); | ||
|
|
There was a problem hiding this comment.
Suggested change
| rl.close() | |
| console.log(`Hi ${name}!`); | |
| console.log(`Hi ${name}!`); | |
| rl.close() |
Comment on lines
+40
to
+41
| or you could use a promise | ||
| ```mjs |
There was a problem hiding this comment.
Suggested change
| or you could use a promise | |
| ```mjs | |
| ```mjs displayName="Promises API" |
And change the other one accordingly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Validation
Related Issues
Check List
npm run formatto ensure the code follows the style guide.npm run testto check if all tests are passing.npx turbo buildto check if the website builds without errors.