Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FR about page #7340

Closed
wants to merge 1 commit into from
Closed

Fix FR about page #7340

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Dec 19, 2024

Remove repetitions and change a couple of words to use the technical idiom in French.

Description

I am French (so a native french speaker)
Reading the About page in French, I found a lot of repetitions, maybe due to a commit/merge issue. I also took the freedom to change a couple of words for their more appropriate french technical idiom (child process > processus fils).

Validation

This only a text update so I assume it should not break anything. Not knowing how the whole NPM stuff works, and not having it installed, I could not run all the tests of the checklist.

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npm run format to ensure the code follows the style guide.
  • I have run npm run test to check if all tests are passing.
  • I have run npx turbo build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

Remove repetitions and change a couple of words to use the technical idiom in French.

Signed-off-by: Florian Manach <113421734+fmanach@users.noreply.github.com>
@ghost ghost self-requested a review as a code owner December 19, 2024 15:59
Copy link

vercel bot commented Dec 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Dec 19, 2024 4:00pm

Copy link
Contributor

Note

Your Pull Request seems to be updating Translations of the Node.js Website.

Whilst we appreciate your intent; Any Translation update should be done through our Crowdin Project.
We recommend giving a read on our Translation Guidelines.

Thank you!

@TenzDelek
Copy link
Contributor

i dont think we are suppose to make changes in localization here. it is done through crowdin

@ghost
Copy link
Author

ghost commented Dec 19, 2024

i dont think we are suppose to make changes in localization here. it is done through crowdin

I clicked the link "Edit this page" from the website... and ended on the GitHub editor from where I made my edits.
You may want to remove the link if it's not the correct method to update the page.

@ghost
Copy link
Author

ghost commented Dec 22, 2024

The french about page still needs to be fixed.

@AugustinMauroy
Copy link
Member

The french about page still needs to be fixed.

First of all, it's not the term “fix” that should be used, but “correct”, because fix is the term for a bug and correct for typography/grammar.

As mentioned above and on the translation.md document, all questions concerning translation are answered on crowdin. So if you think there's something to revise, say so there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants