Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove express example #7359

Merged
merged 1 commit into from
Dec 28, 2024
Merged

chore: remove express example #7359

merged 1 commit into from
Dec 28, 2024

Conversation

ovflowd
Copy link
Member

@ovflowd ovflowd commented Dec 27, 2024

It feels weird to provide an example of one specific framework so in-depth. So this PR removes that example. Note that I'm fine keeping it, but this page was originally migrated from one of the very old guides, and the content wasn't updated.

It feels weird to provide an example of one specific framework so in-depth.

Signed-off-by: Claudio W <cwunder@gnome.org>
@ovflowd ovflowd requested a review from a team as a code owner December 27, 2024 01:04
Copy link

vercel bot commented Dec 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Dec 27, 2024 1:05am

Copy link
Member

@AugustinMauroy AugustinMauroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! but why we still need this ressource ? Because NODE_ENV isn't node core related.

Copy link
Contributor

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 86%
84.47% (631/747) 65.37% (185/283) 83.91% (120/143)

Unit Test Report

Tests Skipped Failures Errors Time
137 0 💤 0 ❌ 0 🔥 5.137s ⏱️

@ovflowd
Copy link
Member Author

ovflowd commented Dec 28, 2024

I don't know, @nodejs/collaborators should we have a guide about NODE_ENV or not?

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ovflowd
Copy link
Member Author

ovflowd commented Dec 28, 2024

Merging this for now, and we can revisit the NODE_ENV in the future.

@ovflowd ovflowd added this pull request to the merge queue Dec 28, 2024
Merged via the queue into main with commit fa9d844 Dec 28, 2024
16 checks passed
@ovflowd ovflowd deleted the chore-remove-express-exampe branch December 28, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants