-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove express example #7359
Conversation
It feels weird to provide an example of one specific framework so in-depth. Signed-off-by: Claudio W <cwunder@gnome.org>
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ! but why we still need this ressource ? Because NODE_ENV
isn't node core related.
I don't know, @nodejs/collaborators should we have a guide about NODE_ENV or not? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Merging this for now, and we can revisit the NODE_ENV in the future. |
It feels weird to provide an example of one specific framework so in-depth. So this PR removes that example. Note that I'm fine keeping it, but this page was originally migrated from one of the very old guides, and the content wasn't updated.