Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): add ui-components package #7401

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

avivkeller
Copy link
Member

@avivkeller avivkeller commented Jan 11, 2025

Warning

This is a draft. It's not ready for merging yet, but a review would be incredibly helpful! 😊

Description

This pull request (PR) introduces the integration of the @node-core/ui-components package into the website's codebase. Most components have been successfully migrated to the new package.

Integration

  • For components requiring additional context or data (e.g., use[Something]()), a with[Component].tsx wrapper has been introduced.
    • For string-based data, a property (e.g., ariaLabel or pathname) has been added to handle the simple content.
  • When a component relies on another component that also requires context from next, a Wrapper={...} property has been added. Ideally, only a minimal number of components should depend on this pattern.

Storybook

  • Currently, Storybook exists in both the apps/site and packages/ui-components folders. The goal is to consolidate Storybook into the packages/ui-components folder before merging this PR (as per @ovflowd's suggestion).

Tailwind

  • The Tailwind configuration is now centralized in the packages/ui-components folder and is imported into the apps/site folder.

@AugustinMauroy If you want to get a head start, feel free to submit a PR into this branch with the new test runner. There's no rush—this isn't a priority right now.

Copy link

vercel bot commented Jan 11, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Jan 11, 2025 1:25am

@AugustinMauroy
Copy link
Member

@AugustinMauroy If you want to get a head start, feel free to submit a PR into this branch with the new test runner. There's no rush—this isn't a priority right now.

No need to rush. Jest still work. Also we need to work step by step.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants