Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug build #112

Merged
merged 9 commits into from
Jan 31, 2024
Merged

Debug build #112

merged 9 commits into from
Jan 31, 2024

Conversation

matthewkeil
Copy link
Contributor

NOTE: Reopened PR #107. Please see that PR for comments and commit history

Hello and thank you for your consideration. I am part of the ChainSafe/lodestar team and we are heavy users of both node and native dependencies. We often have segfaults pop up on our CI through normal course of business and having Node.js built with Debug symbols makes life MUCH easier to debug issues.

We use the Github workflow action actions/setup-node and would like to add a "debug" option to that to have it pull and install a Debug build of node. We have built a fork that creates these releases for ourselves ChainSafe/node_debug but as active contributors to the open source community would like to offer this PR as an addition to the unofficial-builds repo so they everyone in the community can benefit from them as much as we do.

If the images can get built here we will PR our actions/setup-node action back to the main repo so that the binaries are still being served by the node organization instead of our repo. Not sure this is critical but thought it would be more "official" even though its hosted in the "unofficial-builds". A penny for your thoughts on that?

This is my first time contributing to this repo and think I have crossed all my t's and dotted all of my i's but would love some feedback to make sure that it meets standards.

Thanks for the opportunity to give back to the community!

@matthewkeil

@matthewkeil
Copy link
Contributor Author

@rvagg what is the process for submitting versions for the build queue?

@rvagg rvagg merged commit 73522d5 into nodejs:main Jan 31, 2024
@rvagg
Copy link
Member

rvagg commented Jan 31, 2024

@matthewkeil you mean for historical versions? We have a bit of an unresolved problem with that—the Docker build people rely on a stable hash digests for the builds and we can only rebuild all recipes at the moment. I've detailed the problem here: #114

Right now the only option is to wait until the next Node.js release for this recipe to start producing binaries. Or do it manually, but that's a bit too involved and tedious.

@matthewkeil matthewkeil deleted the debug-build branch February 3, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants