Skip to content

Commit

Permalink
Merge pull request #1739 from nodesource/jesus/support-sha256-scripts
Browse files Browse the repository at this point in the history
add new scripts in rpm and docs
  • Loading branch information
JesusPaz authored Jan 2, 2024
2 parents 4f746d9 + 1a56276 commit c1eeb68
Show file tree
Hide file tree
Showing 25 changed files with 1,466 additions and 374 deletions.
32 changes: 8 additions & 24 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,16 +14,9 @@ jobs:
- checkout
- run:
name: Check Node installation
environment:
NODE_MAJOR: 20
command: |
apt-get update
apt-get install -y ca-certificates curl gnupg
apt install nodejs -y
curl -fsSL https://deb.nodesource.com/gpgkey/nodesource-repo.gpg.key | gpg --dearmor -o /etc/apt/keyrings/nodesource.gpg
echo "deb [signed-by=/etc/apt/keyrings/nodesource.gpg] https://deb.nodesource.com/node_${NODE_MAJOR}.x nodistro main" | tee /etc/apt/sources.list.d/nodesource.list
apt-get update
apt-get install nodejs -y
bash ./scripts/deb/setup_lts.x
apt-get install nodejs -y
- run: *envinfo
debian-test:
working_directory: ~/repo
Expand All @@ -33,16 +26,9 @@ jobs:
- checkout
- run:
name: Check Node installation
environment:
NODE_MAJOR: 20
command: |
apt-get update
apt-get install -y ca-certificates curl gnupg
apt install nodejs -y
curl -fsSL https://deb.nodesource.com/gpgkey/nodesource-repo.gpg.key | gpg --dearmor -o /etc/apt/keyrings/nodesource.gpg
echo "deb [signed-by=/etc/apt/keyrings/nodesource.gpg] https://deb.nodesource.com/node_${NODE_MAJOR}.x nodistro main" | tee /etc/apt/sources.list.d/nodesource.list
apt-get update
apt-get install nodejs -y
bash ./scripts/deb/setup_lts.x
apt-get install nodejs -y
- run: *envinfo
amazonlinux-test:
working_directory: ~/repo
Expand All @@ -55,8 +41,8 @@ jobs:
environment:
NODE_MAJOR: 20
command: |
yum install https://rpm.nodesource.com/pub_${NODE_MAJOR}.x/nodistro/repo/nodesource-release-nodistro-1.noarch.rpm -y
yum install nodejs -y --setopt=nodesource-nodejs.module_hotfixes=1
bash ./scripts/rpm/setup_lts.x
yum install nodejs -y
- run: *envinfo
fedora-test:
working_directory: ~/repo
Expand All @@ -66,11 +52,9 @@ jobs:
- checkout
- run:
name: Check Node installation
environment:
NODE_MAJOR: 20
command: |
yum install https://rpm.nodesource.com/pub_${NODE_MAJOR}.x/nodistro/repo/nodesource-release-nodistro-1.noarch.rpm -y
yum install nodejs -y --setopt=nodesource-nodejs.module_hotfixes=1
bash ./scripts/rpm/setup_lts.x
yum install nodejs -y
- run: *envinfo

workflows:
Expand Down
17 changes: 0 additions & 17 deletions .github/ISSUE_TEMPLATE/distribution-support-request.md

This file was deleted.

11 changes: 7 additions & 4 deletions .github/ISSUE_TEMPLATE/issue-bug-report.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,15 +11,18 @@ assignees: ''
A clear and concise description of what the bug is.

**Distribution Information:**
- OS: [e.g. Ubuntu]
- Version [e.g. focal (20.04)]
- Other info if applicable [e.g. Docker image XXX, AWS AMI ID]

- OS: [e.g. Ubuntu]
- Version [e.g. focal (20.04)]
- Other info if applicable [e.g. Docker image XXX, AWS AMI ID]

**Node Version:**
- Node: [e.g. Node.js v18.x:]

- Node: [e.g. Node.js v18.x:]

**To Reproduce**
Steps to reproduce the behavior:

1. Execute Ubuntu Docker Image XX
2. Execute Installation instructions for Node.js v1x.x:
3. ....
Expand Down
20 changes: 5 additions & 15 deletions .github/workflows/CI.yaml → .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: 'Test Installation Scripts'
name: "Test Installation Scripts"

on:
push:
Expand All @@ -22,16 +22,11 @@ jobs:
run:
shell: bash
steps:
- name: Update and Install Dependencies
run: |
apt-get update -y
apt-get install curl git -y
- name: Checkout Repo
uses: actions/checkout@v4

- name: Run Istallation Script
run: ./scripts/nsolid_setup_deb.sh ${{ matrix.version }}
run: ./scripts/rpm/setup_${{ matrix.version }}.x

- name: Install Nodejs
run: |
Expand Down Expand Up @@ -59,20 +54,15 @@ jobs:
run:
shell: bash
steps:
- name: Update and Install Dependencies
run: |
yum update -y
yum install git -y
- name: Checkout Repo
uses: actions/checkout@v4

- name: Run Istallation Script
run: ./scripts/nsolid_setup_rpm.sh ${{ matrix.version }}
run: ./scripts/rpm/setup_${{ matrix.version }}.x

- name: Install Nodejs
run: |
yum install nodejs -y --setopt=nodesource-nodejs.module_hotfixes=1
yum install nodejs -y
- name: Validate Node Version
run: |
Expand All @@ -81,4 +71,4 @@ jobs:
if [[ ${NODE_VERSION} != "v${{ matrix.version }}" ]]; then
echo "Node version is not ${{ matrix.version }}. It is $NODE_VERSION"
exit 1
fi
fi
2 changes: 1 addition & 1 deletion LICENSE.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
The MIT License (MIT)
=====================

Copyright (c) 2019 NodeSource LLC
Copyright (c) 2024 NodeSource LLC
---------------------------------

Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions:
Expand Down
16 changes: 8 additions & 8 deletions OLD_README.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,18 +12,17 @@ Please file an issue if you are experiencing a problem or would like to discuss

Pull requests are encouraged if you have changes you believe would improve the setup process or increase compatibility across Linux distributions.


Looking for the oldversion of [README.md](./OLD_README.md)

## Table of Contents

* **[Debian and Ubuntu based distributions](#deb)** (deb)
- [Installation instructions](#debinstall)
- [Uninstall instructions](#debuninstall)
- [Manual installation](#debmanual)
* [Installation instructions](#debinstall)
* [Uninstall instructions](#debuninstall)
* [Manual installation](#debmanual)
* **[Enterprise Linux based distributions](#rpm)** (rpm)
- [Installation instructions](#rpminstall)
- [Uninstall instructions](#rpmuninstall)
* [Installation instructions](#rpminstall)
* [Uninstall instructions](#rpmuninstall)
* **[Tests](#tests)**
* **[FAQ](#questions)**
* **[Requested Distributions](#requests)**
Expand Down Expand Up @@ -392,7 +391,7 @@ NodeSource will continue to maintain the following architectures and may add add

_NOTE: If you are using RHEL 6 or CentOS 6, you might want to read about [running Node.js on older distros](https://github.com/nodesource/distributions/blob/master/OLDER_DISTROS.md)._

The Nodesource RPM package signing key is available here: https://rpm.nodesource.com/pub/el/NODESOURCE-GPG-SIGNING-KEY-EL
The Nodesource RPM package signing key is available here: <https://rpm.nodesource.com/pub/el/NODESOURCE-GPG-SIGNING-KEY-EL>

Run on RHEL, CentOS, CloudLinux, Amazon Linux or Fedora:

Expand Down Expand Up @@ -511,6 +510,7 @@ To test an installation is working (and that the setup scripts are working!) use

```sh
curl -fsSL https://deb.nodesource.com/test | bash -

```

`<a name="questions"></a>`
Expand Down Expand Up @@ -541,7 +541,7 @@ A: Due to the limitations of the compiler toolchain on EL 5 and its end of gener

---

Q: I'm seeing "Your distribution, identified as "*.i686" or "*.i386, is not currently supported, why?
Q: I'm seeing "Your distribution, identified as "_.i686" or "_.i386, is not currently supported, why?

A: Node.js 4.x and newer require a 64bit os for rpms. See [issue #268](https://github.com/nodesource/distributions/issues/268)

Expand Down
Loading

0 comments on commit c1eeb68

Please sign in to comment.