Prepare for next N|Solid release on v18 Hydrogen #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not going to worry about the overhead of needing to call uv_loop_init() on every call to create() since it's almost never called. This way we don't need to pass in a uv_loop_t on the call. If the overhead is a problem in the future then we'll change it so there's a StatsDEndpoint loop just for that call and add a lock for access so it's thread-safe. PR-URL: #121 Reviewed-by: Santiago Gimeno <santiago.gimeno@gmail.com>
Only tcp and udp are supported, so return early if the protocol doesn't match. PR-URL: #121 Reviewed-by: Santiago Gimeno <santiago.gimeno@gmail.com>
Instead of handling the retry logic in the StatsDAgent, have each connection handle its own endpoint. This way we can abstract the connection class with a future virtual class and allow multiple instances of StatsDAgent to be instantiated. This change also involves other cleanup, and changing the way the timer works so it retries to connect to the StatsD endpoint, after all IP addresses have been tried, every 3 seconds. PR-URL: #121 Reviewed-by: Santiago Gimeno <santiago.gimeno@gmail.com>
Now that connect_() is immediately called after a disconnection, that status is never actually used anymore. PR-URL: #121 Reviewed-by: Santiago Gimeno <santiago.gimeno@gmail.com>
Make it so StatsDTcp and StatsDUdp inherit from the virtual class StatsDConnection. This way the StatsDAgent only needs to keep a single reference to whichever class is being used. This will also make it easier to have multiple instances of StatsDAgent. PR-UR: #122 Reviewed-by: Santiago Gimeno <santiago.gimeno@gmail.com>
Need to let the instance know when it's attempting to write so it doesn't delete itself in the middle of writing out data. PR-UR: #122 Reviewed-by: Santiago Gimeno <santiago.gimeno@gmail.com>
santigimeno
approved these changes
May 9, 2024
PR-URL: #132 Reviewed-by: Santiago Gimeno <santiago.gimeno@gmail.com>
trevnorris
force-pushed
the
trevnorris/prep-for-release
branch
from
85785b1
to
ffe8326
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.