test: fix flaky test-otlp-metrics.mjs #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trevnorris
approved these changes
Jun 17, 2024
Avoid calling `child.send('exit')` multiple times as it might trigger an
`EPIPE` error.
PR-URL: #143
Reviewed-by: Trevor Norris <trev.norris@gmail.com>
santigimeno
force-pushed
the
santi/fix_flaky_grpc_metrics_test
branch
from
a3ee043
to
a184544
Compare
santigimeno
added a commit
that referenced
this pull request
Jun 17, 2024
Avoid calling `child.send('exit')` multiple times as it might trigger an
`EPIPE` error.
PR-URL: #143
Reviewed-by: Trevor Norris <trev.norris@gmail.com>
santigimeno
added a commit
that referenced
this pull request
Jun 20, 2024
Avoid calling `child.send('exit')` multiple times as it might trigger an
`EPIPE` error.
PR-URL: #143
Reviewed-by: Trevor Norris <trev.norris@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid calling
child.send('exit')multiple times as it might trigger anEPIPEerror.