test: fix flaky test when run under load #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
santigimeno
approved these changes
Jun 18, 2024
Running the test with the following:
$ ./tools/test.py -J --repeat=100 test/addons/nsolid-statsdagent/nsolid-statsdagent.js
caused the test to fail in various ways. The fix takes into account that
when the test is slowed down under load it's possible for the
StatsDAgent instance to be ready before it can be checked in JS, and
that the data might have been placed into a single call to 'data'.
Fixes: #142
PR-URL: #144
Reviewed-by: Santiago Gimeno <santiago.gimeno@gmail.com>
trevnorris
force-pushed
the
trevnorris/fix-flaky-statsd-test
branch
from
b6cfe61
to
c6e2cd4
Compare
santigimeno
pushed a commit
that referenced
this pull request
Jun 20, 2024
Running the test with the following:
$ ./tools/test.py -J --repeat=100 test/addons/nsolid-statsdagent/nsolid-statsdagent.js
caused the test to fail in various ways. The fix takes into account that
when the test is slowed down under load it's possible for the
StatsDAgent instance to be ready before it can be checked in JS, and
that the data might have been placed into a single call to 'data'.
Fixes: #142
PR-URL: #144
Reviewed-by: Santiago Gimeno <santiago.gimeno@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running the test with the following:
caused the test to fail in various ways. The fix takes into account that when the test is slowed down under load it's possible for the StatsDAgent instance to be ready before it can be checked in JS, and that the data might have been placed into a single call to 'data'.
Fixes: #142