src: initialize prev_idle_time_ on ThreadMetrics #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trevnorris
approved these changes
Jul 24, 2024
santigimeno
force-pushed
the
santi/fix_loop_metrics_calc
branch
from
c5b6079
to
e1aac60
Compare
juanarbol
approved these changes
Jul 24, 2024
Make sure `prev_idle_time_` is initialized in the `ThreadMetrics::ThreadMetrics(SharedEnvInst envinst)` constructor so the loop utilization calculations are correct, otherwise the default value 0 is used which may lead to meaningless huge values (greater than 1 for the matter). No need to initialize this value in the `ThreadMetrics::ThreadMetrics(uint64_t thread_id)` as this is only used in the `EnvInst` constructor on which having a value of 0 makes sense. PR-URL: #156 Reviewed-by: Trevor Norris <trev.norris@gmail.com> Reviewed-by: Juan José Arboleda <soyjuanarbol@gmail.com>
santigimeno
force-pushed
the
santi/fix_loop_metrics_calc
branch
from
e1aac60
to
5da27a2
Compare
santigimeno
added a commit
that referenced
this pull request
Jul 24, 2024
Make sure `prev_idle_time_` is initialized in the `ThreadMetrics::ThreadMetrics(SharedEnvInst envinst)` constructor so the loop utilization calculations are correct, otherwise the default value 0 is used which may lead to meaningless huge values (greater than 1 for the matter). No need to initialize this value in the `ThreadMetrics::ThreadMetrics(uint64_t thread_id)` as this is only used in the `EnvInst` constructor on which having a value of 0 makes sense. PR-URL: #156 Reviewed-by: Trevor Norris <trev.norris@gmail.com> Reviewed-by: Juan José Arboleda <soyjuanarbol@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure
prev_idle_time_is initialize in theThreadMetrics::ThreadMetrics(SharedEnvInst envinst)constructor so the loop utilization calculations are correct, otherwise the default value 0 is used which may lead to meaningless huge values (greater than 1 for the matter).No need to initialize this value in the
ThreadMetrics::ThreadMetrics(uint64_t thread_id)as this is only used in theEnvInstconstructor on which having a value of 0 makes sense.