agents: implement SpanCollector helper class #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
santigimeno
force-pushed
the
santi/tracing_collector
branch
2 times, most recently
from
608907a
to
cc59147
Compare
trevnorris
approved these changes
Aug 7, 2024
SpanCollector is a class that allows to start collecting spans and report them to a callback function running in a specific uv_loop_t thread. The collector can be configured with a minimum span count and a time interval to report the spans. In addition, the collector can be configured with a transform function that will be applied to the spans before calling the final callback. Use this class to dry the code in the `ZmqAgent` and `OTLPAgent`. PR-URL: #160 Reviewed-By: Trevor Norris <trev.norris@gmail.com>
santigimeno
force-pushed
the
santi/tracing_collector
branch
from
cc59147
to
3ea993c
Compare
trevnorris
pushed a commit
that referenced
this pull request
Aug 21, 2024
SpanCollector is a class that allows to start collecting spans and report them to a callback function running in a specific uv_loop_t thread. The collector can be configured with a minimum span count and a time interval to report the spans. In addition, the collector can be configured with a transform function that will be applied to the spans before calling the final callback. Use this class to dry the code in the `ZmqAgent` and `OTLPAgent`. PR-URL: #160 Reviewed-By: Trevor Norris <trev.norris@gmail.com>
trevnorris
pushed a commit
that referenced
this pull request
Aug 23, 2024
SpanCollector is a class that allows to start collecting spans and report them to a callback function running in a specific uv_loop_t thread. The collector can be configured with a minimum span count and a time interval to report the spans. In addition, the collector can be configured with a transform function that will be applied to the spans before calling the final callback. Use this class to dry the code in the `ZmqAgent` and `OTLPAgent`. PR-URL: #160 Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SpanCollector is a class that allows to start collecting spans and
report them to a callback function running in a specific uv_loop_t
thread. The collector can be configured with a minimum span count and a
time interval to report the spans. In addition, the collector can be
configured with a transform function that will be applied to the spans
before calling the final callback.
Use this class to dry the code in the
ZmqAgentandOTLPAgent.