Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: git node land workflow #188

Closed
wants to merge 3 commits into from
Closed

doc: git node land workflow #188

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
634110f
doc: add project members
RafaelGSS Sep 24, 2024
5f8a492
doc: include landing PR section
RafaelGSS Aug 28, 2024
134b932
doc: add different readme to landing section
RafaelGSS Sep 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 45 additions & 0 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,18 @@ releases addressing crucial issues in N|Solid. N|Solid strives to align its
feature releases as closely as possible with the Node.js release schedule,
promoting harmony and predictability in the release cycles.

### Landing approved Pull Requests

Currently, N|Solid don't use the `commit-queue` label for landing PRs
on _default_ branch. Once the PR is mergeable a maintainer can land it using
`node-core-utils` to include the expected metadata.

```console
$ ncu-config set readme $(PWD)/CONTRIBUTING.md
$ ncu-config set branch node-v20.x-nsolid-v5.x
$ git node land https://github.com/nodesource/nsolid/pull/X
```

## Technical Priorities

The N|Solid project aims to extend Node.js functionality to provide a unified
Expand Down Expand Up @@ -214,6 +226,39 @@ versions of Node.js with safe Buffer allocation.
This type of change has a lot of potential, but also faces the biggest uphill
battle towards becoming a part of the project.

<a id="current-project-team-members"></a>

## Current project team members

<!-- #### TSC voting members -->

<!-- #### TSC regular members -->

<!-- #### TSC emeriti members -->

<!--lint disable prohibited-strings-->

### Collaborators

<!-- node-core-utils and find-inactive-tsc.mjs depend on the format of the TSC
list. If the format changes, those utilities need to be tested and
updated. -->

* [edsadr](https://github.com/edsadr) -
**Adrian Estrada** <<edsadr@gmail.com>> (he/him)
* [juanarbol](https://github.com/juanarbol) -
**Juan José Arboleda** <<soyjuanarbol@gmail.com>> (he/him)
* [RafaelGSS](https://github.com/RafaelGSS) -
**Rafael Gonzaga** <<rafael.nunu@hotmail.com>> (he/him)
* [santigimeno](https://github.com/santigimeno) -
**Santiago Gimeno** <<santiago.gimeno@gmail.com>> (he/him)
* [trevnorris](https://github.com/trevnorris) -
**Trevor Norris** <<trev.norris@gmail.com>>> - (he/him)
* [UlisesGascon](https://github.com/UlisesGascon) -
**Ulises Gascón** <<ulisesgascongonzalez@gmail.com>> (he/him)

<!-- #### Collaborator emeriti -->

<a id="developers-certificate-of-origin"></a>

## Developer's Certificate of Origin 1.1
Expand Down
Loading