Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node v18.20.4 nsolid v5.3.4 release #190

Merged

Conversation

trevnorris
Copy link
Member

No description provided.

santigimeno and others added 6 commits October 4, 2024 09:49
ProfileCollector is a class that allows to start collecting profiles and
report them to a callback function running in a specific uv_loop_t thread.

PR-URL: #161
Reviewed-by: Trevor Norris <trev.norris@gmail.com>
PR-URL: #161
Reviewed-by: Trevor Norris <trev.norris@gmail.com>
PR-URL: #176
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
This commit disables get-released-versions comparison as our base branch
(node-vN.x-nsolid-vX.x) isn't the same as Node.js (main).
So, the check expects that we are running into the `main` branch where
all release commits go to (so the changelog) is up to date.

PR-URL: #174
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
PR-URL: #173
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
PR-URL: #180
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-by: Trevor Norris <trev.norris@gmail.com>
@trevnorris trevnorris self-assigned this Oct 4, 2024
Copy link
Member

@santigimeno santigimeno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

santigimeno and others added 10 commits October 4, 2024 13:07
PR-URL: #180
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-by: Trevor Norris <trev.norris@gmail.com>
PR-URL: #166
Fixes: #163
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
PR-URL: #166
Fixes: #163
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
PR-URL: #166
Fixes: #163
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
PR-URL: #166
Fixes: #163
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
PR-URL: #166
Fixes: #163
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
PR-URL: #166
Fixes: #163
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
PR-URL: #166
Fixes: #163
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
PR-URL: #188
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
@trevnorris trevnorris force-pushed the node-v18.20.4-nsolid-v5.3.4-release branch from e40a1b6 to 9fe792f Compare October 4, 2024 19:09
@trevnorris trevnorris merged commit 1d5c55d into node-v18.x-nsolid-v5.x Oct 4, 2024
12 of 16 checks passed
@trevnorris trevnorris deleted the node-v18.20.4-nsolid-v5.3.4-release branch October 4, 2024 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants