agents: add missing text metrics #193
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `thread.name` is added as an Attribute to every thread metric datapoing as we do with `thread.id`. - `user` and `title` from ProcessMetrics are added to the `Resource` as `process.owner` and `process.title` Attributes respectively.
santigimeno
force-pushed
the
santi/text_metrics
branch
from
1e74c9f
to
350f273
Compare
trevnorris
approved these changes
Oct 14, 2024
santigimeno
added a commit
that referenced
this pull request
Oct 16, 2024
- `thread.name` is added as an Attribute to every thread metric datapoing as we do with `thread.id`. - `user` and `title` from ProcessMetrics are added to the `Resource` as `process.owner` and `process.title` Attributes respectively. PR-URL: #193 Reviewed-By: Trevor Norris <trev.norris@gmail.com>
|
Landed in 6fdd1b7 |
santigimeno
added a commit
that referenced
this pull request
Oct 16, 2024
- `thread.name` is added as an Attribute to every thread metric datapoing as we do with `thread.id`. - `user` and `title` from ProcessMetrics are added to the `Resource` as `process.owner` and `process.title` Attributes respectively. PR-URL: #193 Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
thread.nameis added as an Attribute to every thread metric datapoing as we do withthread.id.userandtitlefrom ProcessMetrics are added to theResourceasprocess.ownerandprocess.titleAttributes respectively.