Multiple changes/fixes in preparation for gRPC #198
Closed
+53
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
santigimeno
commented
Oct 21, 2024
santigimeno
commented
The `Resource` is now updated in `fill_proc_metrics()` so there's no need for every agent to do it.
So they can be either camelCase or snake_case. Out OTLPAgent uses `snake_case`. The upcoming GRPCAgent will use `camelCase`. Also, fix the name of the `gc_dur_us` metric.
trevnorris
approved these changes
Oct 21, 2024
santigimeno
added a commit
that referenced
this pull request
Oct 22, 2024
The `Resource` is now updated in `fill_proc_metrics()` so there's no need for every agent to do it. PR-URL: #198 Reviewed-By: Trevor Norris <trev.norris@gmail.com>
santigimeno
added a commit
that referenced
this pull request
Oct 22, 2024
So they can be either camelCase or snake_case. Out OTLPAgent uses `snake_case`. The upcoming GRPCAgent will use `camelCase`. Also, fix the name of the `gc_dur_us` metric. PR-URL: #198 Reviewed-By: Trevor Norris <trev.norris@gmail.com>
santigimeno
added a commit
that referenced
this pull request
Oct 22, 2024
PR-URL: #198 Reviewed-By: Trevor Norris <trev.norris@gmail.com>
santigimeno
added a commit
that referenced
this pull request
Oct 22, 2024
PR-URL: #198 Reviewed-By: Trevor Norris <trev.norris@gmail.com>
|
Landed in 1c2215d...831810c |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.