Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: cleanup the RunCommand queues on RemoveEnv #25

Merged
merged 4 commits into from
Nov 22, 2023
Merged

src: cleanup the RunCommand queues on RemoveEnv #25

merged 4 commits into from
Nov 22, 2023

Commits on Nov 22, 2023

  1. src: change EnvList::promise_tracking_() signature 

    Pass directly the SharedEnvInst.

PR-URL: #25
Reviewed-by: Santiago Gimeno <santiago.gimeno@gmail.com>
    @santigimeno
    santigimeno committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    209112a View commit details
    Browse the repository at this point in the history

  2. src: fix EnvInst::GetCurrent() 

    Handle the case where the `Environment` is already nullptr.

PR-URL: #25
Reviewed-by: Santiago Gimeno <santiago.gimeno@gmail.com>
    @santigimeno
    santigimeno committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    6f303c7 View commit details
    Browse the repository at this point in the history

  3. src: cleanup the RunCommand queues on RemoveEnv 

    Just to be sure no dangling SharedEnvInst references are left after the
Environment is gone and the EnvInst instance can be deleted.

PR-URL: #25
Reviewed-by: Santiago Gimeno <santiago.gimeno@gmail.com>
    @santigimeno
    santigimeno committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    be6aea6 View commit details
    Browse the repository at this point in the history

  4. src: fix SetupArrayBufferExports() declaration 

    PR-URL: #25
Reviewed-by: Santiago Gimeno <santiago.gimeno@gmail.com>
    @santigimeno
    santigimeno committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    f16e228 View commit details
    Browse the repository at this point in the history